Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate storage on QField and QFC #393

Merged
merged 7 commits into from
Nov 3, 2023
Merged

separate storage on QField and QFC #393

merged 7 commits into from
Nov 3, 2023

Conversation

lucienicolier
Copy link
Member

No description provided.

suricactus
suricactus reviewed Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@suricactus suricactus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a bit of intro for the qfc storage.

documentation/how-to/projects.en.md Outdated Show resolved Hide resolved
documentation/get-started/storage-qfc.en.md Show resolved Hide resolved
lucienicolier and others added 3 commits October 27, 2023 15:24
@lucienicolier @suricactus
Update documentation/how-to/projects.en.md
3f2d613 
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
@lucienicolier @suricactus
Update documentation/get-started/storage-qfc.en.md
384e8a3 
Co-authored-by: Ivan Ivanov <suricactus@users.noreply.github.com>
@lucienicolier
fix whitespace
8838f87
@nirvn
Copy link
Member

nirvn commented Oct 27, 2023

Will this link in QField need updating: https://github.com/opengisch/QField/blob/master/src/qml/QFieldLocalDataPickerScreen.qml#L567 ?

@lucienicolier
Copy link
Member Author

Will this link in QField need updating: https://github.com/opengisch/QField/blob/master/src/qml/QFieldLocalDataPickerScreen.qml#L567 ?

Good point! Yes, it will.

@nirvn
Copy link
Member

nirvn commented Oct 27, 2023

I'm wondering if we should avoid changing the URL for QField storage when splitting the cloud part out. We've used that crucial link quite a lot when helping ppl deal with Android storage. Ppl on social media linked to it too.

@lucienicolier
Copy link
Member Author

I'm wondering if we should avoid changing the URL for QField storage when splitting the cloud part out. We've used that crucial link quite a lot when helping ppl deal with Android storage. Ppl on social media linked to it too.

I can keep the one for QField and only change the one for QFC

@nirvn
Copy link
Member

nirvn commented Oct 27, 2023

@lucienicolier , that sounds like a better option to me, thanks.

@suricactus suricactus merged commit aaa37e8 into master Nov 3, 2023
1 of 2 checks passed
@suricactus suricactus deleted the storage branch November 3, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-kuhn m-kuhn m-kuhn left review comments

@suricactus suricactus suricactus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucienicolier @nirvn @m-kuhn @suricactus