Fix toggle column action in the discover page #8905
Conversation
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 8905.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
Signed-off-by: Tony Lee <tony.lee@dtexsystems.com>
Signed-off-by: Tony Lee <tony.lee@dtexsystems.com>
tungsheng
force-pushed
the
fix/8698-toggle-column
branch
from
c72b308
to
bf4cc6e
Compare
|
@abbyhu2000 Would you kindly help with the WhiteSource Security Check fail in this PR? Any required action on my side? Is there a way to re-run the checks? Thank you! 🙏 |
tungsheng
changed the title
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Tony Lee <tony.lee@dtexsystems.com>
tungsheng
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
tungsheng
requested review from
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
tungsheng
changed the title
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
tungsheng
changed the title
let me re-run the check and see if it passes~ |
There was a problem hiding this comment.
nice! Thanks for the unit test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8905 +/- ##
=======================================
Coverage 60.87% 60.87%
=======================================
Files 3802 3802
Lines 91072 91072
Branches 14375 14375
=======================================
Hits 55444 55444
Misses 32086 32086
Partials 3542 3542
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| * The OpenSearch Contributors require contributions made to | ||
| * this file be licensed under the Apache-2.0 license or a | ||
| * compatible open source license. | ||
| * | ||
| * Any modifications Copyright OpenSearch Contributors. See | ||
| * GitHub history for details. | ||
| */ | ||
|
|
||
| /* | ||
| * Licensed to Elasticsearch B.V. under one or more contributor | ||
| * license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright | ||
| * ownership. Elasticsearch B.V. licenses this file to you under | ||
| * the Apache License, Version 2.0 (the "License"); you may | ||
| * not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ |
There was a problem hiding this comment.
I think this is the older license header, should be the following now:
/*
* Copyright OpenSearch Contributors
* SPDX-License-Identifier: Apache-2.0
*/
There was a problem hiding this comment.
Will update it to the new license. Thank you for pointing it out!!
Signed-off-by: Tony Lee <tony.lee@dtexsystems.com>
|
@abbyhu2000 I am not sure how to trigger the WhiteSource Security Check from my side. Could you help review and trigger the check? or let me know what I can do to trigger, thank you for your help! |
Description
The
DocViewerTabcomponent needs to be updated when thecolumnsprop is updated.This PR
columnsprop check in theshouldComponentUpdatelifecycle method.columnsprop changed.Issues Resolved
fixes
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration