-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix toggle column action in the discover page #8905
Open
tungsheng
wants to merge
9
commits into
opensearch-project:main
Choose a base branch
from
tungsheng:fix/8698-toggle-column
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+37
−0
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9204dd9
Update DocViewerTab if columns is changed
tungsheng bf4cc6e
Add unit test for DocViewerTab prop 'columns' changed
tungsheng f6a4460
Add changeset file
tungsheng 58f5a29
Merge branch 'main' into fix/8698-toggle-column
tungsheng 6956c77
Changeset file for PR #8905 created/updated
opensearch-changeset-bot[bot] 47b09f8
Merge branch 'main' into fix/8698-toggle-column
tungsheng 9f310fb
Merge branch 'main' into fix/8698-toggle-column
tungsheng 6f1d474
Use the new license header
tungsheng f77259b
Merge branch 'main' into fix/8698-toggle-column
tungsheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
fix: | ||
- Fix toggle column action in the discover page ([#8905](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8905)) |
34 changes: 34 additions & 0 deletions
34
src/plugins/discover/public/application/components/doc_viewer/doc_viewer_tab.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/* | ||
* Copyright OpenSearch Contributors | ||
* SPDX-License-Identifier: Apache-2.0 | ||
*/ | ||
|
||
import React from 'react'; | ||
import { mount } from 'enzyme'; | ||
import { DocViewerTab, DocViewerTabProps } from './doc_viewer_tab'; | ||
import { DocViewRenderProps } from '../../doc_views/doc_views_types'; | ||
|
||
test('DocViewerTab updated when getting new renderProps', () => { | ||
const MockComp = ({ columns }: DocViewRenderProps) => ( | ||
<div data-test-subj="test-div">{columns![0]}</div> | ||
); | ||
|
||
const mockProps: DocViewerTabProps = { | ||
id: 1, | ||
title: 'Test1', | ||
component: MockComp, | ||
renderProps: { | ||
hit: { _id: '1' }, | ||
columns: ['test1'], | ||
}, | ||
}; | ||
|
||
const wrapper = mount(<DocViewerTab {...mockProps} />); | ||
|
||
const div = wrapper.find({ 'data-test-subj': 'test-div' }); | ||
expect(div.text()).toEqual('test1'); | ||
|
||
mockProps.renderProps = { hit: { _id: '1' }, columns: ['test2'] }; | ||
wrapper.setProps(mockProps); | ||
expect(div.text()).toEqual('test2'); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! Thanks for the unit test