Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit tests: fix deprecation notices on PHPUnit 10 #9

Commits on Sep 12, 2024

  1. PHPUnit tests: fix deprecation notices on PHPUnit 10

    PHPUnit 11 will be stricter about the data passed from data providers to test methods.
    * The amount of parameters passed has to match the expected number of parameters exactly.
    * If the data sets use keys, the parameter names have to match the keys as used in each data set (inner array).
    
    PHPUnit 10 warns about these changes via deprecation notices.
    
    As the success and fail tests use the same input and to avoid duplication, I've added some interim data provider methods to prevent the deprecation notices and allow for update to PHPUnit 11, while still avoiding data duplication.
    jrfnl committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c83b7e5 View commit details
    Browse the repository at this point in the history