PHPUnit tests: fix deprecation notices on PHPUnit 10 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHPUnit 11 will be stricter about the data passed from data providers to test methods. * The amount of parameters passed has to match the expected number of parameters exactly. * If the data sets use keys, the parameter names have to match the keys as used in each data set (inner array). PHPUnit 10 warns about these changes via deprecation notices. As the success and fail tests use the same input and to avoid duplication, I've added some interim data provider methods to prevent the deprecation notices and allow for update to PHPUnit 11, while still avoiding data duplication.
|
Thank you @jrfnl! Not a proper review from me, but I'll trust you this is right. |
jrfnl
deleted the
feature/tests-phpunit10-prevent-phpunit-deprecation-notices
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPUnit 11 will be stricter about the data passed from data providers to test methods.
PHPUnit 10 warns about these changes via deprecation notices.
As the success and fail tests use the same input and to avoid duplication, I've added some interim data provider methods to prevent the deprecation notices and allow for update to PHPUnit 11, while still avoiding data duplication.