Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9486] maint: Update CI and publishing #356

Merged
merged 34 commits into from
Jul 10, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely commented Jul 3, 2023

Summary

  • Large updates to C# CI workflow
  • Add release workflow to this repo
  • Remove Travis from release build and publish
  • Remove AWS S3 for artifact storage and use GitHub's native artifact handling (expires after 90 days, though)

Need to release branch v3.11.3, and I'm taking the opportunity to revamp DevOps

Test plan

  • No code paths changed, so unit & integration tests should continue to work
  • Review the recent test runs of the workflow

Issues

  • FSSDK-9486

@mikechu-optimizely
Copy link
Contributor Author

This PR needs to be merged BEFORE
#357
#358

@mikechu-optimizely mikechu-optimizely requested review from msohailhussain and removed request for yasirfolio3 July 5, 2023 13:21
@mikechu-optimizely mikechu-optimizely requested review from jaeopt and removed request for a team and msohailhussain July 6, 2023 18:41
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! A couple of suggestions.

.github/workflows/csharp.yml Show resolved Hide resolved
@mikechu-optimizely
Copy link
Contributor Author

Later, I'll need to remove the CI and deployment secrets supporting AWS uploads.

@mikechu-optimizely
Copy link
Contributor Author

Temporarily closing to avoid CI runs

@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review July 7, 2023 15:03
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - so I guess with this change, we now can remove the codesign repo completely?

@mikechu-optimizely mikechu-optimizely merged commit b658323 into master Jul 10, 2023
15 checks passed
@mikechu-optimizely mikechu-optimizely deleted the mike/remote-build-on-release branch July 10, 2023 14:49
@mikechu-optimizely
Copy link
Contributor Author

LGTM - so I guess with this change, we now can remove the codesign repo completely?

@jaeopt I think we should archive it for sure, so it's not used.

@mikechu-optimizely
Copy link
Contributor Author

I need to cherry-pick these changes to the PR for the release-3.11.3 branch next.

mikechu-optimizely added a commit that referenced this pull request Jul 10, 2023
* Add remote dispatch workflow

* Update job & step names

* Stop uploading to AWS

* Reorganized jobs

* Change workflow names

* Fix on.push.branches for testing

* Rename job

* Rename steps; remove second strong name signing

for .NET Framework assems

* Combine two steps

* Run tests before release build

* NIT changes

* Move NUnit tests after build

* Remove testing branch push trigger

* Renamings; remove test trigger

* Rename jobs for consistency

* Revert "Rename jobs for consistency"

This reverts commit c159538.

* Update from @jaeopt PR review

* Add back CI_USER_TOKEN secret

* Add back TRAVIS_COM_TOKEN

* Update release workflow for testing

* Fix test tag

* Testing fix use OptimizelySDK.Travis.sln since

I'm testing using previous release

* Adjust names

* Migrate nuspec template

* Fix checkout during pack; output tag & version

* Fix output of env.TAG

* Shorten & fix during testing

* Add back jobs

* Update OptimizelySDK.nuspec.template's permission

* Iterate on nuspec creation

* Fix semantic extraction

* Fix dotnet nuget push

* Move env to steps where they're needed

* Remove testing setups

(cherry picked from commit b658323)
mikechu-optimizely added a commit that referenced this pull request Jul 18, 2023
* [FSSDK-9472] fix: Last-Modified header not respected  (#355)

* Fix where Last-Modified is pulled

* Corrected small problems in test class

* WIP Adding Last Modified test

* Add test coverage

WIP: new tests succeed in isolation (time-based/brittle)

* Fix failing test by deferring

* Lint fixes

* Lint fix whitespace

(cherry picked from commit 471ca4b)

* Fixed follow-on merge issues

* [FSSDK-9486] maint: Update CI and publishing (#356)

* Add remote dispatch workflow

* Update job & step names

* Stop uploading to AWS

* Reorganized jobs

* Change workflow names

* Fix on.push.branches for testing

* Rename job

* Rename steps; remove second strong name signing

for .NET Framework assems

* Combine two steps

* Run tests before release build

* NIT changes

* Move NUnit tests after build

* Remove testing branch push trigger

* Renamings; remove test trigger

* Rename jobs for consistency

* Revert "Rename jobs for consistency"

This reverts commit c159538.

* Update from @jaeopt PR review

* Add back CI_USER_TOKEN secret

* Add back TRAVIS_COM_TOKEN

* Update release workflow for testing

* Fix test tag

* Testing fix use OptimizelySDK.Travis.sln since

I'm testing using previous release

* Adjust names

* Migrate nuspec template

* Fix checkout during pack; output tag & version

* Fix output of env.TAG

* Shorten & fix during testing

* Add back jobs

* Update OptimizelySDK.nuspec.template's permission

* Iterate on nuspec creation

* Fix semantic extraction

* Fix dotnet nuget push

* Move env to steps where they're needed

* Remove testing setups

(cherry picked from commit b658323)

* Lint fixes 🥲

* Sort imports for linting

* Sort alphabetically
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants