-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FSSDK-9486] chore: Prepare for releasing 3.11.3 #358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - date in changelog should be updated
LGTM - Curious to know why fullstack check is failing. |
Great catch @muzahidul-opti I missed that because apparently I don't have the checks configured correctly. Let me look into both before continuing.... |
Oh wait, branch checks are configured for ...but yeah why is optimizely/fullstack-sdk-compatibility-suite showing failure....hmmm |
Found it. I'm building SDK version 3.11.3, which does not have any coding for ATS/ODP. FSC is using end-to-end tests (csharp-testapp) that has ODP in play and expects the SDK to have the ODP classes so the build is failing I need to think about how to use an older tag of the csharp-testapp that did not expect ODP to be present 🤔 |
Grrr. Ok. TestApp built successfully using an older non-ODP version, but now FSC itself needs to be run using a version before adding ODP. 58 failing tests all appear to be ODP. |
@yasirfolio3 Is there a way to run FSC at a point before ODP tests? |
Thanks |
Summary
Test plan
Issues