Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FSSDK-9486] chore: Prepare for releasing 3.11.3 #358

Merged
merged 7 commits into from
Jul 19, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

  • Increment semantic version number in assemblies
  • Update CHANGELOG

Test plan

  • Only release prep. No code paths changed.
  • All existing tests should continue to pass.

Issues

  • FSSDK-9472
  • FSSDK-9486

@mikechu-optimizely
Copy link
Contributor Author

PRs #356 & #357 need to be merged into the release-branch before this one.

@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review July 18, 2023 17:53
@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner July 18, 2023 17:53
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - date in changelog should be updated

CHANGELOG.md Outdated Show resolved Hide resolved
@muzahidul-opti
Copy link

muzahidul-opti commented Jul 18, 2023

LGTM - Curious to know why fullstack check is failing.

@mikechu-optimizely
Copy link
Contributor Author

LGTM - Curious to know why fullstack check is failing.

Great catch @muzahidul-opti I missed that because apparently I don't have the checks configured correctly. Let me look into both before continuing....

@mikechu-optimizely
Copy link
Contributor Author

Oh wait, branch checks are configured for master and we're merging into release-3.11.3.

...but yeah why is optimizely/fullstack-sdk-compatibility-suite showing failure....hmmm

@mikechu-optimizely
Copy link
Contributor Author

Found it.

I'm building SDK version 3.11.3, which does not have any coding for ATS/ODP. FSC is using end-to-end tests (csharp-testapp) that has ODP in play and expects the SDK to have the ODP classes so the build is failing

I need to think about how to use an older tag of the csharp-testapp that did not expect ODP to be present 🤔

@muzahidul-opti

@mikechu-optimizely
Copy link
Contributor Author

Grrr. Ok. TestApp built successfully using an older non-ODP version, but now FSC itself needs to be run using a version before adding ODP.

58 failing tests all appear to be ODP.

@muzahidul-opti @jaeopt

@mikechu-optimizely
Copy link
Contributor Author

@yasirfolio3 Is there a way to run FSC at a point before ODP tests?

@mikechu-optimizely
Copy link
Contributor Author

Thanks
@yasirfolio3 for pointing me in the direction of passing e2e testing for non ODP C#
@muzahidul-opti for catching my oversight on e2e
@jaeopt for your 3 reviews to get this out the door.

@mikechu-optimizely mikechu-optimizely merged commit 97b240a into release-3.11.3 Jul 19, 2023
@mikechu-optimizely mikechu-optimizely deleted the mike/prep-release-3-11-3 branch July 19, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants