Moving config from ADS to UI for unverified models #976
Conversation
…ence into ODSC-61938/fix_validation_for_gguf_safetensors
kumar-shivam-ranjan
requested review from
darenr,
mayoor,
mrDzurb,
VipulMascarenhas,
qiuosier and
ahosler
as code owners
oracle-contributor-agreement
bot
added
the
OCA Verified
ads/aqua/finetuning/finetuning.py
Outdated
| logger.info(f"Fetching default fine-tuning config for model: {model_id}") | ||
| config = get_finetuning_config_defaults() | ||
| logger.info( | ||
| f"default fine-tuning config will be used for model: {model_id}" |
There was a problem hiding this comment.
this info message can be misleading since user might see this in ads logs and expect some default to be returned, but the defaults are applied outside of ads. Maybe a better phrasing would be "Fine-tuning config for custom model {model_id} is not available." We can also use logger.debug instead, user need not see this message every time.
@mrDzurb thoughts?
| AQUA_MODEL_DEPLOYMENT_CONFIG, | ||
| AQUA_MODEL_DEPLOYMENT_CONFIG_DEFAULTS, |
There was a problem hiding this comment.
can you please the unused constants and json files/functions that were deprecated here since we're not using them anymore?
There was a problem hiding this comment.
Sorry didn't understand this statement. perhaps you a word or two?
There was a problem hiding this comment.
I missed the word - " can you please remove or delete the unused constants and json files/functions that were deprecated..." :)
There was a problem hiding this comment.
Sure , will update
UI changes are ready. I was under assumption that only embedding changes + adding logs in terminal are part of release this week. But if we plan to release config migration changes as well , we can. Looping @mayoor @NitinMore7 |
|
Please add more details in the description. It will be helpful for the future maintenance. |
yes, let's switch target to main if we're comfortable with the UI changes to go this week. |
kumar-shivam-ranjan
dismissed
mrDzurb’s stale review
The base branch was changed.
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
|
📌 Cov diff with main: 📌 Overall coverage: |
This PR is intended to remove dependency of unverified models default config from ADS.
Currently, the default shapes config for deployment, finetuning and evaluation are hardcoded in ADS. This makes it difficult to make changes ad-hoc with new ADS release.
This info is needed for unverified models only and can be maintained at client side.
Config that needs to be removed are
UTs