-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving config from ADS to UI for unverified models #976
Merged
Merged
Changes from 12 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9810f0c
Fix validation for model containing both formats.
lu-ohai dc7b47d
Updated pr.
lu-ohai 7d966b5
Merge branch 'main' of https://github.com/oracle/accelerated-data-sci…
lu-ohai eb785ca
Fix validation for model containing both formats. (#948)
lu-ohai 0c6b422
Adding early stopping params for FT
kumar-shivam-ranjan a8780ea
Merge branch 'main' into feature/aqua-v1.0.5
mrDzurb 08b3dfe
Addressing review comment
kumar-shivam-ranjan 28c5d26
Fixing UTs
kumar-shivam-ranjan 0814b7c
moving params to AQUAFineTunedParams
kumar-shivam-ranjan b441ea7
Passing Early stopping params to SMC container for finetuning (#970)
kumar-shivam-ranjan 49da2cd
Moving config from ADS to UI
kumar-shivam-ranjan 6d9c1a1
Moving config from ADS to UI
kumar-shivam-ranjan da5fb1a
Addressing review comments
kumar-shivam-ranjan 68178d4
Resolving conflicts
kumar-shivam-ranjan f2f3ac3
Removing unused config for unverified models
kumar-shivam-ranjan 77857dc
Fixing UTs
kumar-shivam-ranjan b3e415b
formatting
kumar-shivam-ranjan fc734e6
Fixing UI handler UT
kumar-shivam-ranjan 7239ff2
formatting
kumar-shivam-ranjan 692fb61
Resolving conflicts
kumar-shivam-ranjan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this info message can be misleading since user might see this in ads logs and expect some default to be returned, but the defaults are applied outside of ads. Maybe a better phrasing would be "Fine-tuning config for custom model {model_id} is not available." We can also use logger.debug instead, user need not see this message every time.
@mrDzurb thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated