Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wind plugin pause #668

Merged
merged 3 commits into from
Jun 21, 2023
Merged

fix wind plugin pause #668

merged 3 commits into from
Jun 21, 2023

Conversation

j-herman
Copy link
Collaborator

@j-herman j-herman commented Jun 5, 2023

Test: run VRX normally. Echo one of the wind topics, eg:

gz topic --echo --topic /vrx/debug/wind/speed

Pause the simulation. You should see the topic stop publishing. Unpause, watch the messages scroll.

@M1chaelM
Copy link
Collaborator

M1chaelM commented Jun 5, 2023

This is working for me, so I'm ready to approve, but I'm waiting to see whether it resolves issue #666 raised by @alexdrc00

@caguero caguero requested a review from M1chaelM June 20, 2023 18:32
@M1chaelM M1chaelM self-assigned this Jun 20, 2023
@M1chaelM M1chaelM linked an issue Jun 20, 2023 that may be closed by this pull request
Copy link
Collaborator

@M1chaelM M1chaelM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Also resolves #666

@j-herman j-herman merged commit ebd7f7f into main Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WorldControl service bridge error in 2.2
3 participants