Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make various changes and clean up scripts #40

Merged
merged 6 commits into from
Nov 17, 2023
Merged

Make various changes and clean up scripts #40

merged 6 commits into from
Nov 17, 2023

Conversation

Electroid
Copy link
Contributor

No description provided.

@autofix-troubleshooter
Copy link

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

@Electroid Electroid merged commit a93230d into main Nov 17, 2023
22 checks passed
@Electroid Electroid deleted the clean-up branch November 17, 2023 23:58
@jord1e
Copy link

jord1e commented Nov 26, 2023

@Electroid you broke #27

a93230d#diff-0ab5f4d9b6ac7c64ba34246032bebb7d567daffdc4724e50769bd38c6d9c4c66L28

a93230d#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R34

It should be (in src/index.ts)

- version: getInput("bun-version") || readVersionFromPackageJson() || undefined,
+ version: readVersionFromPackageJson() || getInput("bun-version") || undefined,

because getInput("bun-version") always returns the default value (which is latest), so the readVersionFromPackageJson() is never called.

Would be great if we can get a 1.1.1 out quickly (@xhyrom ).

Also,

-     if (!packageManager?.startsWith("bun@")) {
+    if (!packageManager?.includes("bun@")) {

Yarn does some weird stuff when doing yarn run which might still be necessary in setups where only bun install is used:
image

Real package.json:
image

replacing startsWith with includes will fix this

@xhyrom
Copy link
Collaborator

xhyrom commented Nov 26, 2023

@Electroid you broke #27

a93230d#diff-0ab5f4d9b6ac7c64ba34246032bebb7d567daffdc4724e50769bd38c6d9c4c66L28

a93230d#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R34

It should be (in src/index.ts)

- version: getInput("bun-version") || readVersionFromPackageJson() || undefined,
+ version: readVersionFromPackageJson() || getInput("bun-version") || undefined,

because getInput("bun-version") always returns the default value (which is latest), so the readVersionFromPackageJson() is never called.

Would be great if we can get a 1.1.1 out quickly (@xhyrom ).

I didn't catch that, thanks! Well I can publish it tomorrow (UTC+1) because I'm not on computer so I can't build the code.

@jord1e
Copy link

jord1e commented Nov 26, 2023

@Electroid you broke #27
a93230d#diff-0ab5f4d9b6ac7c64ba34246032bebb7d567daffdc4724e50769bd38c6d9c4c66L28
a93230d#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R34
It should be (in src/index.ts)

- version: getInput("bun-version") || readVersionFromPackageJson() || undefined,
+ version: readVersionFromPackageJson() || getInput("bun-version") || undefined,

because getInput("bun-version") always returns the default value (which is latest), so the readVersionFromPackageJson() is never called.
Would be great if we can get a 1.1.1 out quickly (@xhyrom ).

I didn't catch that, thanks! Well I can publish it tomorrow (UTC+1) because I'm not on computer so I can't build the code.

I did not expect the quick reply, please see the edit to fix another bug/inconvenience in one go :)

@xhyrom
Copy link
Collaborator

xhyrom commented Nov 26, 2023

@Electroid you broke #27
a93230d#diff-0ab5f4d9b6ac7c64ba34246032bebb7d567daffdc4724e50769bd38c6d9c4c66L28
a93230d#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R34
It should be (in src/index.ts)

- version: getInput("bun-version") || readVersionFromPackageJson() || undefined,
+ version: readVersionFromPackageJson() || getInput("bun-version") || undefined,

because getInput("bun-version") always returns the default value (which is latest), so the readVersionFromPackageJson() is never called.
Would be great if we can get a 1.1.1 out quickly (@xhyrom ).

I didn't catch that, thanks! Well I can publish it tomorrow (UTC+1) because I'm not on computer so I can't build the code.

I did not expect the quick reply, please see the edit to fix another bug/inconvenience in one go :)

GitHub actions built it, so I'll release it in few minutes

@jord1e jord1e mentioned this pull request Nov 26, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants