-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build image from Fedora base #36
Conversation
0b05693
to
847b1a2
Compare
847b1a2
to
2799f2e
Compare
This is also ready for review. And also have to discuss on whether to keep or remove ubuntu image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to me. The Dockerfile and configs look good.
Please note that Fedora is a short-lived distribution and they tend to break things with every release. I'd recommend you to slowly transition back to Ubuntu LTS later on.
So, we need to have both (Ubuntu and Fedora) as for now? And then slowly discard Fedora if using Ubuntu22.04LTS works. |
Possible tags with this PR: |
let's change the tagging to be more consistent and then I think we can merge this |
5d74461
to
17d1417
Compare
What I was trying to say is, let's use Fedora 36 if it works now so that the tests are running again. Then, we have time until Fedora 36 becomes EOL to transition back to, e.g., Ubuntu. |
Since there is an issue with running ubuntu22 based image in drone-ci (see #34), with this PR, the image can be built on Fedora base which works in drone-ci.
Remaining tasks: