Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build image from Fedora base #36

Merged
merged 10 commits into from
Aug 30, 2022

Conversation

saw-jan
Copy link
Collaborator

@saw-jan saw-jan commented Aug 24, 2022

Since there is an issue with running ubuntu22 based image in drone-ci (see #34), with this PR, the image can be built on Fedora base which works in drone-ci.

Remaining tasks:

@saw-jan
Copy link
Collaborator Author

saw-jan commented Aug 25, 2022

This is also ready for review. And also have to discuss on whether to keep or remove ubuntu image.

CC @individual-it @TheOneRing @fmoc

@saw-jan saw-jan marked this pull request as ready for review August 25, 2022 11:37
Copy link
Contributor

@fmoc fmoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. The Dockerfile and configs look good.

Please note that Fedora is a short-lived distribution and they tend to break things with every release. I'd recommend you to slowly transition back to Ubuntu LTS later on.

@saw-jan
Copy link
Collaborator Author

saw-jan commented Aug 29, 2022

Seems reasonable to me. The Dockerfile and configs look good.

Please note that Fedora is a short-lived distribution and they tend to break things with every release. I'd recommend you to slowly transition back to Ubuntu LTS later on.

So, we need to have both (Ubuntu and Fedora) as for now? And then slowly discard Fedora if using Ubuntu22.04LTS works.

@saw-jan
Copy link
Collaborator Author

saw-jan commented Aug 29, 2022

Possible tags with this PR:
fedora: fedora, fedora-6.7-20220106-1008-qt515x-linux64, fedora-36-6.7-20220106-1008-qt515x-linux64
latest: latest, 6.7-20220106-1008-qt515x-linux64, u22.04-6.7-20220106-1008-qt515x-linux64
qt512: qt512, qt512-6.7-20210421-1504-qt512x-linux64

CC @individual-it @fmoc

@individual-it
Copy link
Contributor

let's change the tagging to be more consistent and then I think we can merge this
fedora: fedora, fedora-6.7-20220106-1008-qt515x-linux64, fedora-36-6.7-20220106-1008-qt515x-linux64
latest: latest, ubuntu-6.7-20220106-1008-qt515x-linux64, ubuntu-22.04-6.7-20220106-1008-qt515x-linux64
qt512: qt512, qt512-6.7-20210421-1504-qt512x-linux64

@fmoc
Copy link
Contributor

fmoc commented Aug 29, 2022

So, we need to have both (Ubuntu and Fedora) as for now? And then slowly discard Fedora if using Ubuntu22.04LTS works.

What I was trying to say is, let's use Fedora 36 if it works now so that the tests are running again. Then, we have time until Fedora 36 becomes EOL to transition back to, e.g., Ubuntu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants