Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui-tests-only] Unskip vfs tests #10073

Merged
merged 2 commits into from
Sep 6, 2022
Merged

[gui-tests-only] Unskip vfs tests #10073

merged 2 commits into from
Sep 6, 2022

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Sep 1, 2022

Previously, the vfs tests failed because of trying to enable vfs feature before the user account was set up. In this PR, I have added wait for files to sync step so that the enabling vfs action will be successful.

This PR unskips the vfs tests.

Related issues:

part of #10072

@saw-jan saw-jan added the QA:team label Sep 1, 2022
@saw-jan saw-jan self-assigned this Sep 1, 2022
@saw-jan saw-jan marked this pull request as ready for review September 1, 2022 11:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amrita-shrestha amrita-shrestha merged commit f1c9cd4 into master Sep 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the unskip-vfs-tests branch September 6, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants