fix: remove unreachable exception handling #855
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 40s |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 30s |
|
Pull request merge failed: Changes must be made through the merge queue |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 24s |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Remove the unreachable ‹except› block. Since the ‹collaborators› is populated from a helper method that can produce only exceptions that are wrapped in the ogr's exceptions (handled by the metaclass), hence the ‹github.GithubException› cannot be raised. Fixes packit#760 Signed-off-by: Matej Focko <mfocko@redhat.com>
updates: - [github.com/psf/black: 24.2.0 → 24.8.0](psf/black@24.2.0...24.8.0) - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) - [github.com/pre-commit/mirrors-mypy: v1.8.0 → v1.11.2](pre-commit/mirrors-mypy@v1.8.0...v1.11.2) - [github.com/teemtee/tmt.git: 1.31.0 → 1.35.0](https://github.com/teemtee/tmt.git/compare/1.31.0...1.35.0) - [github.com/astral-sh/ruff-pre-commit: v0.2.2 → v0.6.3](astral-sh/ruff-pre-commit@v0.2.2...v0.6.3) - [github.com/python-jsonschema/check-jsonschema: 0.28.0 → 0.29.2](python-jsonschema/check-jsonschema@0.28.0...0.29.2) (cherry picked from commit 255093d) Closes packit#847 (by superseding) Signed-off-by: Matej Focko <mfocko@redhat.com>
Signed-off-by: Matej Focko <mfocko@redhat.com>
mfocko
force-pushed
the
fix/remove-redundant-try-catch
branch
from
f1fbc2f
to
dd63af3
Compare
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 22s |
mfocko
added
mergeit
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 22s |
softwarefactory-project-zuul
bot
merged commit 7daaa24
into
packit:main
Remove the unreachable ‹except› block. Since the ‹collaborators› is populated from a helper method that can produce only exceptions that are wrapped in the ogr's exceptions (handled by the metaclass), hence the ‹github.GithubException› cannot be raised.
Fixes #760