Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unreachable exception handling #855

Merged
merged 3 commits into from
Sep 4, 2024
Merged

fix: remove unreachable exception handling #855

merged 3 commits into from
Sep 4, 2024

Commits on Sep 4, 2024

  1. fix: remove unreachable exception handling 

    Remove the unreachable ‹except› block. Since the ‹collaborators› is
populated from a helper method that can produce only exceptions that
are wrapped in the ogr's exceptions (handled by the metaclass), hence
the ‹github.GithubException› cannot be raised.

Fixes packit#760

Signed-off-by: Matej Focko <mfocko@redhat.com>
    @mfocko
    mfocko committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    357f0ad View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] pre-commit autoupdate 

    updates:
- [github.com/psf/black: 24.2.0 → 24.8.0](psf/black@24.2.0...24.8.0)
- [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0)
- [github.com/pre-commit/mirrors-mypy: v1.8.0 → v1.11.2](pre-commit/mirrors-mypy@v1.8.0...v1.11.2)
- [github.com/teemtee/tmt.git: 1.31.0 → 1.35.0](https://github.com/teemtee/tmt.git/compare/1.31.0...1.35.0)
- [github.com/astral-sh/ruff-pre-commit: v0.2.2 → v0.6.3](astral-sh/ruff-pre-commit@v0.2.2...v0.6.3)
- [github.com/python-jsonschema/check-jsonschema: 0.28.0 → 0.29.2](python-jsonschema/check-jsonschema@0.28.0...0.29.2)

(cherry picked from commit 255093d)

Closes packit#847 (by superseding)

Signed-off-by: Matej Focko <mfocko@redhat.com>
    @pre-commit-ci @mfocko
    pre-commit-ci[bot] authored and mfocko committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    25ea161 View commit details
    Browse the repository at this point in the history

  3. style: fix ruff complaints 

    Signed-off-by: Matej Focko <mfocko@redhat.com>
    @mfocko
    mfocko committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    dd63af3 View commit details
    Browse the repository at this point in the history