-
Notifications
You must be signed in to change notification settings - Fork 37
2020.06.03 Meeting Notes
Andrew Gaspar edited this page Jun 3, 2020
·
5 revisions
- Individual/group updates
- Discuss/share current threading/concurrency model (pgrete)
- Usage of FORCEINLINE macro (pgrete)
- Quick run-through of outstanding non-WIP pull request reviews
- Discuss offline the best strategy for 1) doing performance tests and 2) automating them
- Start Profiling Code w/o AMR
- F. Glines
- J. Miller (~a little bit)
- Start Kokkosifying AMR
- Assignment of execution spaces to mesh blocks (necessary for performance)
- P. Grete
- Porting for functionality (just get things not crashing and working correctly)
- J. Dolence
- A. Gaspar
- Assignment of execution spaces to mesh blocks (necessary for performance)
- tbd
Got the Kokkosification change merged.
Testing GPU performance. 100x worse performance for small mesh block sizes (16^3) in uniform static grid. https://github.com/lanl/parthenon/issues/189
Joshua and Andrew started porting kokkos AMR code: https://github.com/lanl/parthenon/pull/177 Tests:
- calculate_pi + CPU
- calculate_pi + GPU + serial
- calculate_pi + GPU + parallel
- advection + GPU + serial
- advection + GPU + parallel
In progress implementation of code coverage: https://github.com/lanl/parthenon/pull/187
Discussion of our concurrency strategy.
We think this is maybe causing issues for IPO with Intel. Need to check. Phil will verify that it's actually FORCEINLINE causing the issue.