Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ciliatedness --> ciliated + add mono and multi ciliated #562

Merged
merged 5 commits into from
Aug 12, 2024
Merged

Conversation

dosumis
Copy link
Contributor

@dosumis dosumis commented Jul 23, 2024

Fixes #561

@rays22 - I'd like to get this out ASAP as needed for multiple HCA projects. Could you give it a quick review. Thanks!

comment --> def
@dosumis
Copy link
Contributor Author

dosumis commented Jul 23, 2024

CC @Caroline-99

Copy link
Collaborator

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change or drop the wikipedia xref Wikipedia:http\://en.wikipedia.org/wiki/Ciliated] for PATO:0001408.

src/ontology/pato-edit.obo Outdated Show resolved Hide resolved
src/ontology/pato-edit.obo Outdated Show resolved Hide resolved
Fix xref from wikipedia "Ciliated" to "Cilium".
src/ontology/pato-edit.obo Outdated Show resolved Hide resolved
Fix link to wikipedia article.
@rays22 rays22 merged commit 79b80a6 into master Aug 12, 2024
1 check passed
@rays22 rays22 deleted the multiciliated branch August 12, 2024 11:27
@sbello
Copy link
Contributor

sbello commented Aug 12, 2024

Nico asked me to look at this today, I know it has been merged but I have a couple comments/questions

  • Is there a reason you didn't use the GO definition of cilum (GO:0005929)?
  • Personally circular definitions bug me, so defining ciliated as having cilia without defining cilia feels insufficient to me. I would have used part of the GO definition of cilia in the definition 'specialized eukaryotic organelle that consists of a filiform extrusion of the cell surface and of some cytoplasmic parts' So the definition would be
    A cellular quality inhering in a bearer by virtue of the bearer's having as a part one or more organelles consisting of a filiform extrusion of the cell surface and of some cytoplasmic parts.

If the term is not meant to define cilia as in GO it would be good to clarify the definition to make this clear.

@rays22
Copy link
Collaborator

rays22 commented Aug 12, 2024

I had taken the CGI (General Class Axiom) associated with ciliated into consideration (which does reference GO cilium) in my review, and I saw no need to request changes in @dosumis 's textual definition:
image

@dosumis
Copy link
Contributor Author

dosumis commented Sep 2, 2024

@sbello - as Ray notes - we do have a link to GO - via GCI. This was a major motivation for me in adding the term. Not keen to copy and paste text from GO term def as GO term may evolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ciliatedness --> ciliated + add mono and multi ciliated subclasses
5 participants