Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for issue with testHashMethodNeedsToBeInComparingProtocol #2

Merged
merged 7 commits into from
Sep 2, 2020
Merged

Update for issue with testHashMethodNeedsToBeInComparingProtocol #2

merged 7 commits into from
Sep 2, 2020

Conversation

akevalion
Copy link

Update for test ProperMethodCategorizationTest >> #testHashMethodNeedsToBeInComparingProtocol

Because Roassal3 uses last version of geometry

akevalion and others added 7 commits June 10, 2020 01:44
@akevalion
Added
e2233da 
- asPoint for GPoint
- fix GEllipse intersectionsWithLine: for empty ellipses
- Added class comment for GEllipse
- GRectangle now accepts empty rectangles
- remove manifest package tag
@akevalion @jecisc
Update src/Geometry/GEllipse.class.st
ac88422 
suggested by @jecisc

Co-authored-by: CyrilFerlicot <cyril@ferlicot.me>
@akevalion
added some tests with an empty ellipse
0d1d674
@akevalion
Merge ac88422
b78baa5
@akevalion
rollback to keep the concept a point is not a rectangle
e33bcad
@akevalion
In geometry there are not empty circles or rectangles
89a4bf8
@akevalion
Update for test ProperMethodCategorizationTest >> #testHashMethodNeed…
d890f34 
…sToBeInComparingProtocol

Because Roassal3 uses last version of geometry
@akevalion akevalion mentioned this pull request Aug 27, 2020
Merged
@akevalion
Copy link
Author

@jecisc this pull request is for pull request pharo-project/pharo#7163 (comment)

@akevalion akevalion mentioned this pull request Aug 29, 2020
Open
@akevalion
Copy link
Author

Hi @noha could you please review/accept this pull request?
This is related to issues:
pharo-project/pharo#7163 (comment) and
TelescopeSt#21

Thank you

@noha noha merged commit 28e1b67 into pharo-contributions:master Sep 2, 2020
@jecisc
Copy link
Member

jecisc commented Sep 2, 2020

Sorry for the delay, I am currently on holidays and I'm not often on the computer.

Thanks Norbert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akevalion @jecisc @noha