6755-Integrate-Roassal3

[Ducasse]

fixes: #6755 Include roassal30 0.9.2 'Core' 'Tests'

[Ducasse]

ObjectProfile/Roassal3#275

[tesonep]

Hi, @akevalion

These tests are failing, they are validations of the quality of the code, please check what it is missing.

• This test is failing because there are unused temporaries left. Please check them.

NoUnusedTemporaryVariablesLeftTest >> #testNoUnusedTemporaryVariablesLeft

• These tests are failing because there are invalid categorized methods

ProperMethodCategorizationTest >> #testCopyMethodNeedsToBeInCopyingProtocol
ProperMethodCategorizationTest >> #testHashMethodNeedsToBeInComparingProtocol
ProperMethodCategorizationTest >> #testPostCopyMethodNeedsToBeInCopyingProtocol
ProperMethodCategorizationTest >> #testSetUpMethodInSUnitTestsNeedsToBeInRunningProtocol

• Check that there are some #setUp message not calling super as first operation.
  ProperlyImplementedSUnitClassesTest >> #testAndMakeSureSuperSetupIsCalledAsFirstMessageInSetupMethodsOfTestCases

• Methods from traits are duplicated and not marked as should be implemented.
  ReleaseTest >> #testExplicitRequirementMethodsShouldBeImplementedInTheirUsers
  ReleaseTest >> #testLocalMethodsOfTheClassShouldNotBeRepeatedInItsTraits

• There are initialization to nil of instance variables
  ReleaseTest >> #testNoNilAssignmentInInitializeMethod

• Missing help in a world menu option.
  ReleaseTest >> #testWorldMenuHasHelpForAllEntries

• There are settings without default values, or the default value does not match with the real one in the image.
  SystemSettingsPersistenceTest >> #testDefaultImageDoesNotStoreAnySetting

[akevalion]

Hi @tesonep I will update roassal keeping in mind this tests

[Ducasse]

Thanks!

[akevalion]

Hi @tesonep I have changed Roassal3 considering your commend.

ObjectProfile/Roassal3@8a9eaa6

Also I have create pull requests to fix:

• testHashMethodNeedsToBeInComparingProtocol in Update for issue with testHashMethodNeedsToBeInComparingProtocol pharo-contributions/Geometry#2

• testNoUnusedTemporaryVariablesLeft in update for issue with test NoUnusedTemporaryVariablesLeftTest >> #testNoUnusedTemporaryVariablesLeft pharo-contributions/Athens-SVG#3

[tesonep]

I have pushed a new commit targeting the commit in roassal that @akevalion has done.
If this works, we can make a release of Roassal and point there.

[tesonep]

@akevalion I tried with the commit you added and there is a problem with a #hash method not in "comparing" category
Check the test ProperMethodCategorizationTest>>testHashMethodNeedsToBeInComparingProtocol

[akevalion]

@akevalion I tried with the commit you added and there is a problem with a #hash method not in "comparing" category
Check the test ProperMethodCategorizationTest>>testHashMethodNeedsToBeInComparingProtocol

That is related to the pull request for this repository:

• testHashMethodNeedsToBeInComparingProtocol in Update for issue with testHashMethodNeedsToBeInComparingProtocol pharo-contributions/Geometry#2
• and testNoUnusedTemporaryVariablesLeft in update for issue with test NoUnusedTemporaryVariablesLeftTest >> #testNoUnusedTemporaryVariablesLeft pharo-contributions/Athens-SVG#3

Should I talk with someone in order to have these PRs accepted?

[Ducasse]

Can you issue PRs to such projects? this way I will see if I can integrate them.

[akevalion]

I have created issues for that pull requests in each repository Geometry Athens-SVG Cheers El sáb., 29 ago. 2020 a las 9:47, StéphaneDucasse (<notifications@github.com>) escribió:

…

Can you issue PRs to such projects? this way I will see if I can integrate them. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7163 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACQLQGSTTYZDNLB3DEGKU5TSDEBFPANCNFSM4QIBTW6Q> .

[akevalion]

Athens-SVG has accepted my pull request.

Now wait for Geometry

[Ducasse]

May be you should ping norbert.

[akevalion]

@tesonep Norbert has accepted the Pull request for Geometry!

[tesonep]

I have updated the baseline, if it goes we can go for the release of Roassal

[tesonep]

Ok @akevalion, can you do a release so we can point to the release and see how to follow.
Thanks