Fix annoying popup error.

[Rodrigo-Barros]

Hello from Brazil.

Hey I see that someone started a feature to debug trace messages between vscode and phpactor language server but was not in the client code, so I opened this pull request.

What this feature do is: control the popup terminal window show, based on value of phpactor.trace.server.vebosity.

set "off" for phpactor.trace.server do not popup the terminal window when a request fail.

Note: I update the version in package.json and I add mkdir to help automatically create the artifacts folder too.

---

I have one doubt. I run the phpactor via socket in a virtual machine running Linux, and accessed via socket on windows machine everything worked as expected, but only for tag 0.18.1. This is supposed to be happen or is something related to current refactoring.

[dantleech]

I have one doubt. I run the phpactor via socket in a virtual machine running Linux, and accessed via socket on windows machine everything worked as expected, but only for tag 0.18.1. This is supposed to be happen or is something related to current refactoring.

i'm not sure -- what happens that is not as expected? is it a separate issue?

[dantleech]

is this the same feature? is there some documentation / comparable language server extension to compare with?

[dantleech]

intelliphense just disables it: https://github.com/bmewburn/vscode-intelephense/blob/master/src/extension.ts#L158

[dantleech]

also maybe the confusion is because the settings for phpactor.trace.server in package.json is automatically used by vscode - and controls if code will verbosely log the communication between client and server... it doesn't need any corresponding code in the extension itself.. perhaps there is another setting for revealing the window on error.

... although also good to report the error that is being triggered so it can be fixed :)

[Rodrigo-Barros]

is this the same feature? is there some documentation / comparable language server extension to compare with?

Yes is the same feature, sorry if I misunderstand.

also maybe the confusion is because the settings for phpactor.trace.server in package.json is automatically used by vscode

I don't knew it.

i'm not sure -- what happens that is not as expected? is it a separate issue?

Yes it is. I wiil open a issue to not blend the subjects.

Thank you for your time.

[dantleech]

Yes is the same feature, sorry if I misunderstand.

I mean.. why should the trace verbosity affect if the output channel is revealed? what makes you think this is how it should be done?

[Rodrigo-Barros]

Yes is the same feature, sorry if I misunderstand.

I mean.. why should the trace verbosity affect if the output channel is revealed? what makes you think this is how it should be done?

Hi again, I think must have an option to disable the annoying error pop up, even if another json key must be created only for that. In debug scenarios this could be enabled or maybe set the default value to show the popup, but could be disabled by the user.