Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix annoying popup error. #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix annoying popup error. #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "vscode-phpactor",
"version": "1.1.0",
"version": "1.2.1",
"description": "Phpactor PHP Language Server extension for vscode",
"main": "lib/extension.js",
"publisher": "dantleech",
Expand All @@ -14,7 +14,7 @@
],
"scripts": {
"clean": "rimraf lib",
"build-vsce": "vsce package --out=artifacts/phpactor.vsix",
"build-vsce": "mkdir -p artifacts && vsce package --out=artifacts/phpactor.vsix",
"build": "npm run compile && npm run build-vsce",
"prepare": "yarn clean && yarn build",
"watch": "tsc -watch -p ./",
Expand Down
11 changes: 10 additions & 1 deletion src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import {
ServerOptions,
LanguageClientOptions,
StreamInfo,
RevealOutputChannelOn
} from "vscode-languageclient";

import * as vscode from "vscode";
Expand Down Expand Up @@ -85,13 +86,21 @@ function getServerOptions(config): ServerOptions
function createClient(config: any): LanguageClient {
let serverOptions = getServerOptions(config);

let {verbosity} = config.trace.server;
let trace = {
"off" : RevealOutputChannelOn.Never,
"message" : RevealOutputChannelOn.Warn,
"verbose" : RevealOutputChannelOn.Info
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the same feature? is there some documentation / comparable language server extension to compare with?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intelliphense just disables it: https://github.com/bmewburn/vscode-intelephense/blob/master/src/extension.ts#L158

}

let clientOptions: LanguageClientOptions = {
documentSelector: [
{ language: LanguageID, scheme: 'file' },
{ language: 'blade', scheme: 'file' },
{ language: LanguageID, scheme: 'untitled' }
],
initializationOptions: config.config
initializationOptions: config.config,
revealOutputChannelOn: trace[verbosity]
};

languageClient = new LanguageClient(
Expand Down