Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix no result #88

Closed
wants to merge 4 commits into from
Closed

[Bug] Fix no result #88

wants to merge 4 commits into from

Conversation

mattamon
Copy link
Contributor

Codeception fails if no result is obtained due to trying to access property on null.
https://github.com/pimcore/web-to-print-bundle/actions/runs/11472288862/job/31924629146

@mattamon mattamon added the Bug label Oct 23, 2024
@mattamon mattamon added this to the 1.3.2 milestone Oct 23, 2024
@kingjia90
Copy link
Contributor

kingjia90 commented Oct 24, 2024

Thank you for fixing the tests, however i believe it is not fixing the underlying issue which seems caused by a BC BREAK from the release of PDFReactor v12 on 16th October (the exact date when it started the series of not passing the tests).

image

@kingjia90
Copy link
Contributor

Maybe related to #22

@mattamon
Copy link
Contributor Author

Thank you for fixing the tests, however i believe it is not fixing the underlying issue which seems caused by a BC BREAK from the release of PDFReactor v12 on 16th October (the exact date when it started the series of not passing the tests).

image

Question is, if we can fix it without a BC-Break ourselves?

@kingjia90
Copy link
Contributor

kingjia90 commented Oct 24, 2024

Good question 🤔
If we rely on their cloud service, we(and devs,partners) have no other choices other than to adapt to it, as they do not seem to provide a sort of LTS or versioning for the APIs

$config['pdfreactorServer'] = 'cloud.pdfreactor.com';

It could be also that they had an unintentional regression and may be fixed soon

@mattamon
Copy link
Contributor Author

Good question 🤔
If we rely on their cloud service, we(and devs,partners) have no other choices other than to adapt to it, as they do not seem to provide a sort of LTS or versioning for the APIs

$config['pdfreactorServer'] = 'cloud.pdfreactor.com';

It could be also that they had an unintentional regression and may be fixed soon

Could this also be a license problem?
https://www.pdfreactor.com/pricing/ seems like you need to buy it and have an apikey?

@kingjia90 kingjia90 self-assigned this Nov 7, 2024
@fashxp
Copy link
Member

fashxp commented Nov 7, 2024

I'm in contact with realobjects. As @kingjia90 suspected, this behavior is a result of their new major release PDFreactor 12 ... which returns errors when configuration is invalid/wrong.
Currently checking, what we can do and what versions we can support in parallel.

@fashxp
Copy link
Member

fashxp commented Nov 7, 2024

alternative approach see #89

@kingjia90 kingjia90 removed this from the 1.3.2 milestone Nov 7, 2024
@mattamon
Copy link
Contributor Author

mattamon commented Nov 7, 2024

Closing in favor of #89

@mattamon mattamon closed this Nov 7, 2024
@kingjia90 kingjia90 deleted the fix-no-result branch November 7, 2024 14:00
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants