Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for PDFreactor 11 #89

Merged
merged 22 commits into from
Nov 18, 2024
Merged

Added support for PDFreactor 11 #89

merged 22 commits into from
Nov 18, 2024

Conversation

fashxp
Copy link
Member

@fashxp fashxp commented Nov 7, 2024

fixes #22

alternative for #88

@fashxp fashxp added this to the 1.3.2 milestone Nov 7, 2024
@fashxp fashxp mentioned this pull request Nov 7, 2024
@kingjia90 kingjia90 linked an issue Nov 7, 2024 that may be closed by this pull request
@AlternateIf
Copy link

@fashxp
is this forcing version 12 of pdfreactor?
https://github.com/pimcore/web-to-print-bundle/blob/support-pdfreactor-11/src/Processor/Api/PDFreactor.class.php#L779

i tried using this for a v11 pdfreactor and got a
"Invalid client data. Cannot deserialize value of type int from String "12.0.0": not a valid int value"

When changing the const to a int
public const VERSION = 12;
it seems to work for my pdfreactor 11

@fashxp
Copy link
Member Author

fashxp commented Nov 8, 2024

Hmm, should not, will check with pdfreactor guys. Thx for reporting...

@fashxp fashxp marked this pull request as draft November 8, 2024 15:06
@fashxp
Copy link
Member Author

fashxp commented Nov 14, 2024

@AlternateIf could you please double check if the latest changes work for you?

@fashxp fashxp marked this pull request as ready for review November 15, 2024 10:04
@fashxp
Copy link
Member Author

fashxp commented Nov 18, 2024

@AlternateIf I'll merge it for now ... if there remain some problems we need to address this in followup PRs.

@fashxp fashxp self-assigned this Nov 18, 2024
@fashxp fashxp merged commit 0d6a215 into 1.3 Nov 18, 2024
9 checks passed
@fashxp fashxp deleted the support-pdfreactor-11 branch November 18, 2024 07:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PDFReactor] enableDebugMode is deprecated
3 participants