Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schemaStorage(ticdc): remove schemaVersion in schemaStorage (#11869) #11920

Open
wants to merge 1 commit into
base: release-8.5
Choose a base branch
from

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11869

What problem does this PR solve?

Issue Number: close #11868

What is changed and how it works?

This PR removes the SchemaVersion field and its associated logic from the schemaStorage component in TiCDC. The change is part of an effort to remove schema change checking and reduce redundant logic.

Related to #11733.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note

None

@ti-chi-bot ti-chi-bot added lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Dec 20, 2024
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. labels Dec 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gozssky for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2024

@ti-chi-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdc-integration-pulsar-test 51da60e link true /test cdc-integration-pulsar-test
pull-cdc-integration-kafka-test 51da60e link true /test cdc-integration-kafka-test
jenkins-ticdc/verify 51da60e link true /test verify
pull-cdc-integration-mysql-test 51da60e link true /test cdc-integration-mysql-test
pull-cdc-integration-storage-test 51da60e link true /test cdc-integration-storage-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-8.5@3703b18). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc ∅ <0.0000%> (?)
dm 50.0654% <0.0000%> (?)
engine 53.2505% <0.0000%> (?)
Flag Coverage Δ
unit 50.8756% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.5     #11920   +/-   ##
================================================
  Coverage               ?   50.8756%           
================================================
  Files                  ?        484           
  Lines                  ?      69666           
  Branches               ?          0           
================================================
  Hits                   ?      35443           
  Misses                 ?      31471           
  Partials               ?       2752           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants