-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schemaStorage(ticdc): remove schemaVersion
in schemaStorage
(#11869)
#11920
base: release-8.5
Are you sure you want to change the base?
schemaStorage(ticdc): remove schemaVersion
in schemaStorage
(#11869)
#11920
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ti-chi-bot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## release-8.5 #11920 +/- ##
================================================
Coverage ? 50.8756%
================================================
Files ? 484
Lines ? 69666
Branches ? 0
================================================
Hits ? 35443
Misses ? 31471
Partials ? 2752 |
This is an automated cherry-pick of #11869
What problem does this PR solve?
Issue Number: close #11868
What is changed and how it works?
This PR removes the
SchemaVersion
field and its associated logic from theschemaStorage
component in TiCDC. The change is part of an effort to remove schema change checking and reduce redundant logic.Related to #11733.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note