Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schemaStorage(ticdc): remove schemaVersion in schemaStorage #11869

Merged
merged 2 commits into from
Dec 20, 2024
Merged

schemaStorage(ticdc): remove schemaVersion in schemaStorage #11869

merged 2 commits into from
Dec 20, 2024

Conversation

wlwilliamx
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #11868

What is changed and how it works?

This PR removes the SchemaVersion field and its associated logic from the schemaStorage component in TiCDC. The change is part of an effort to remove schema change checking and reduce redundant logic.

Related to #11733.

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No.

Do you need to update user documentation, design documentation or monitoring documentation?

No.

Release note 

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 12, 2024
@wk989898
Copy link
Collaborator

/retest

@wlwilliamx
Copy link
Contributor Author

wlwilliamx commented Dec 18, 2024 •
edited
Loading

@wk989898 No need to retest. There is indeed an issue here. I will address it after I finish organizing the details of TiCDC and TiDB DDL.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. and removed do-not-merge/needs-triage-completed labels Dec 20, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, hongyunyan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 20, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-12-20 09:36:45.664339356 +0000 UTC m=+1208795.753141888: ☑️ agreed by hongyunyan.
  • 2024-12-20 10:22:11.774238803 +0000 UTC m=+1211521.863041343: ☑️ agreed by CharlesCheung96.

@ti-chi-bot ti-chi-bot bot merged commit c5b8800 into pingcap:master Dec 20, 2024
26 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 20, 2024
@wlwilliamx @ti-chi-bot
This is an automated cherry-pick of pingcap#11869
3b5ba5c 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11916.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 20, 2024
Open
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 20, 2024
@wlwilliamx @ti-chi-bot
This is an automated cherry-pick of pingcap#11869
2f2cd41 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11917.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 20, 2024
Open
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 20, 2024
@wlwilliamx @ti-chi-bot
This is an automated cherry-pick of pingcap#11869
c5111c7 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11918.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 20, 2024
Merged
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Dec 20, 2024
@wlwilliamx @ti-chi-bot
This is an automated cherry-pick of pingcap#11869
8362b37 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11919.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 20, 2024
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #11920.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 20, 2024
Open
ti-chi-bot bot pushed a commit that referenced this pull request Dec 21, 2024
@ti-chi-bot
schemaStorage(ticdc): remove schemaVersion in schemaStorage (#11869…
5e61d5a 
…) (#11918)

close #11868
CharlesCheung96 added a commit to CharlesCheung96/tiflow that referenced this pull request Dec 22, 2024
@CharlesCheung96
Revert "schemaStorage(ticdc): remove schemaVersion in `schemaStorag…
6e7a75b 
…e` (pingcap#11869)"

This reverts commit c5b8800.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@hongyunyan hongyunyan hongyunyan approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ticdc: remove schema version management from schemaStorage
5 participants
@wlwilliamx @wk989898 @ti-chi-bot @hongyunyan @CharlesCheung96