Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 📦 version packages #970

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Conversation

t3dotgg
Copy link
Member

@t3dotgg t3dotgg commented Sep 20, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

uploadthing@7.1.0

Minor Changes

Patch Changes

@uploadthing/expo@7.0.3

Patch Changes

@uploadthing/nuxt@7.0.3

Patch Changes

@uploadthing/react@7.0.3

Patch Changes

@uploadthing/shared@7.0.3

Patch Changes

  • #977 2afabe5 Thanks @juliusmarminge! - chore: remove internal dropzone package to prevent peer dependency conflicts between package managers

  • #989 53f4ab6 Thanks @juraj98! - fix vite monorepos sometimes complaining about $RefreshSig$ is not a function

  • #991 fe83f4a Thanks @juliusmarminge! - fix: prefer browser recognized mime type over file extension lookup when matching file's type to router config

@uploadthing/solid@7.0.3

Patch Changes

@uploadthing/svelte@7.0.3

Patch Changes

@uploadthing/vue@7.0.3

Patch Changes

@github-actions github-actions bot force-pushed the changeset-release/main branch from 0d30a72 to fe957b1 Compare September 20, 2024 07:12
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-uploadthing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 9:47pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
legacy-docs-uploadthing ⬜️ Ignored (Inspect) Visit Preview Oct 8, 2024 9:47pm

Copy link
Contributor

coderabbitai bot commented Sep 20, 2024

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 24 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Files that changed from the base of the PR and between 3598102 and 32464db.

Walkthrough

This pull request introduces updates to the @uploadthing/react, @uploadthing/expo, and uploadthing packages, incrementing their version numbers from 7.0.2 to 7.0.3 and from 7.0.2 to 7.1.0, respectively. The changes primarily address the pluralization of the dropzone label based on maxFileCount in the @uploadthing/react package and enforce a return type of JSONObject for the onUploadComplete callback in the uploadthing package. Additionally, several package.json files across various example projects have been updated to reflect the new dependency versions.

Changes

File(s) Change Summary
.changeset/cool-boats-look.md Deleted file contained a patch for pluralization of dropzone label when maxFileCount exceeds 1.
.changeset/ten-pillows-smile.md Deleted file contained a patch for onUploadComplete callback enforcing a return type of JSONObject.
examples/backend-adapters/*.json, examples/minimal-*.json, examples/with-*.json Updated @uploadthing/react version from 7.0.2 to 7.0.3.
examples/minimal-expo/package.json Updated @uploadthing/expo version from 7.0.2 to 7.0.3.
packages/expo/CHANGELOG.md Updated changelog for @uploadthing/expo to include version 7.0.3.
packages/expo/package.json Updated @uploadthing/expo version from 7.0.2 to 7.0.3.
packages/react/CHANGELOG.md Updated changelog for @uploadthing/react to include version 7.0.3 and pluralization fix.
packages/react/package.json Updated @uploadthing/react version from 7.0.2 to 7.0.3.
packages/uploadthing/CHANGELOG.md Updated changelog for uploadthing to include version 7.1.0 and a fix for onUploadComplete.
packages/uploadthing/package.json Updated uploadthing version from 7.0.2 to 7.1.0.
packages/shared/CHANGELOG.md, packages/shared/package.json, packages/solid/CHANGELOG.md, packages/solid/package.json, packages/svelte/CHANGELOG.md, packages/svelte/package.json, packages/vue/CHANGELOG.md, packages/vue/package.json Updated various packages to version 7.0.3.

Possibly related PRs

  • fix: enforce JSONObject return in onUploadComplete #968: The changes enforce that the onUploadComplete callback must return a JSONObject, which is directly related to the functionality of the upload process mentioned in the main PR.
  • chore: remove dropzone pacakge #977: This PR involves the removal of the internal dropzone package to prevent peer dependency conflicts, which aligns with the changes in the main PR that also address aspects of the upload functionality.
  • chore(release): 📦 version packages #951: This PR includes updates to the uploadthing package, which encompasses the changes made in the main PR regarding the pluralization of the dropzone label and other related functionalities.

Suggested labels

📚 documentation

Suggested reviewers

  • juliusmarminge
  • markflorkowski

Poem

🐰 In the garden where the bunnies play,
New versions hop in, brightening the day.
Labels now dance with a plural flair,
Uploading files with a joyful air!
With each little change, we cheer and we leap,
For updates like these, our hearts brightly beep! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e3096f5 and 4fdebd2.

Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing (19)
  • .changeset/cool-boats-look.md (0 hunks)
  • examples/backend-adapters/client-react/package.json (1 hunks)
  • examples/backend-adapters/package.json (1 hunks)
  • examples/minimal-appdir/package.json (1 hunks)
  • examples/minimal-astro-react/package.json (1 hunks)
  • examples/minimal-expo/package.json (1 hunks)
  • examples/minimal-pagedir/package.json (1 hunks)
  • examples/with-clerk-appdir/package.json (1 hunks)
  • examples/with-clerk-pagesdir/package.json (1 hunks)
  • examples/with-clerk-remix/package.json (1 hunks)
  • examples/with-drizzle-appdir/package.json (1 hunks)
  • examples/with-drizzle-pagesdir/package.json (1 hunks)
  • examples/with-novel/package.json (1 hunks)
  • examples/with-react-image-crop/package.json (1 hunks)
  • examples/with-tailwindcss/package.json (1 hunks)
  • packages/expo/CHANGELOG.md (1 hunks)
  • packages/expo/package.json (1 hunks)
  • packages/react/CHANGELOG.md (1 hunks)
  • packages/react/package.json (1 hunks)
Files not reviewed due to no reviewable changes (1)
  • .changeset/cool-boats-look.md
Files skipped from review due to trivial changes (2)
  • packages/expo/package.json
  • packages/react/package.json
Additional comments not posted (16)
examples/backend-adapters/client-react/package.json (1)

11-11: LGTM!

Updating the @uploadthing/react dependency to the latest patch version 7.0.3 is a good practice to ensure the project benefits from the latest fixes and improvements.

examples/minimal-pagedir/package.json (1)

12-12: LGTM!

The dependency version update of @uploadthing/react from 7.0.2 to 7.0.3 is correct and aligns with the PR objective.

examples/minimal-astro-react/package.json (1)

15-15: LGTM!

The @uploadthing/react dependency version has been updated to 7.0.3, which includes a fix for the dropzone label pluralization based on the maxFileCount. This update ensures that the example project is using the latest version of the package with the necessary fixes.

examples/with-react-image-crop/package.json (1)

12-12: LGTM!

The update to the @uploadthing/react dependency version is a routine change and is unlikely to introduce any issues.

Please ensure that the example project runs as expected with the updated dependency by running the following commands:

Verify that the image cropping functionality works as expected and that there are no console errors or warnings.

Verification successful

Update to @uploadthing/react appears safe

Based on the analysis of the project files, the update of @uploadthing/react from 7.0.2 to 7.0.3 is unlikely to cause any issues:

  • The usage of @uploadthing/react is limited to importing specific functions and styles.
  • No code directly related to dropzone label pluralization was found, which was the main change in this update.
  • The update is isolated to the @uploadthing/react package and doesn't affect the main uploadthing package.

While we couldn't run the project directly, the code inspection suggests that the update should be safe to apply.

If possible, it would be beneficial to manually verify the dropzone functionality in the running application to ensure the label pluralization works as expected with different maxFileCount values.

Scripts executed

The following scripts were executed for the analysis:

Script:

cd examples/with-react-image-crop
npm install
npm run dev

Length of output: 205


Script:

#!/bin/bash
# Inspect package.json and related files
echo "Contents of package.json:"
cat examples/with-react-image-crop/package.json

echo "\nFiles that import or use @uploadthing/react:"
rg "@uploadthing/react" examples/with-react-image-crop -l

echo "\nContents of files using @uploadthing/react:"
rg "@uploadthing/react" examples/with-react-image-crop -C 5

Length of output: 3713

examples/minimal-appdir/package.json (1)

12-12: LGTM!

The update to the @uploadthing/react dependency version from 7.0.2 to 7.0.3 is a minor version bump, which typically introduces new features or non-breaking changes. According to the AI-generated summary, this update addresses the pluralization of the dropzone label based on the maxFileCount in the @uploadthing/react package.

Updating the dependency version in the package.json file is a standard practice to incorporate the latest changes. This change is unlikely to introduce any breaking changes or compatibility issues since it's a minor version bump.

examples/with-tailwindcss/package.json (1)

12-12: Dependency version update looks good!

The @uploadthing/react dependency has been updated from version 7.0.2 to 7.0.3. This aligns with the PR objective of releasing updated packages and ensures the example project uses the latest patch version.

examples/with-clerk-remix/package.json (1)

17-17: LGTM!

The @uploadthing/react dependency has been correctly updated to version 7.0.3, which aligns with the release objectives.

examples/with-novel/package.json (1)

16-16: LGTM!

The @uploadthing/react dependency has been updated to version ^7.0.3, which aligns with the PR objective of releasing updated packages. This update is unlikely to introduce breaking changes and ensures the package uses the latest version of the dependency.

examples/with-clerk-appdir/package.json (1)

15-15: LGTM!

The @uploadthing/react dependency has been updated to the latest patch version 7.0.3. This update is unlikely to introduce breaking changes and ensures that the example project is using the most recent version of the package.

examples/with-clerk-pagesdir/package.json (1)

15-15: LGTM!

The minor version update to @uploadthing/react from 7.0.2 to 7.0.3 is a safe and beneficial change. It ensures that the project uses the latest compatible version of the library, which includes a bug fix for the pluralization of the dropzone label based on the maxFileCount.

examples/with-drizzle-appdir/package.json (1)

15-15: Dependency update looks good, but review the changelog.

Updating the @uploadthing/react dependency from version 7.0.2 to 7.0.3 is a minor version bump, which should generally be safe to integrate.

However, it's still recommended to review the changelog or release notes of the @uploadthing/react package to understand any new features, changes, or fixes introduced in version 7.0.3. This will help ensure compatibility with your project and identify any potential impact or necessary adjustments.

examples/with-drizzle-pagesdir/package.json (1)

15-15: LGTM!

The update to the @uploadthing/react dependency version from 7.0.2 to 7.0.3 is appropriate. This minor version update includes a fix for the pluralization of the dropzone label based on maxFileCount, as mentioned in the PR objectives.

Updating the dependency version in this package.json file ensures that the example project uses the latest version of the @uploadthing/react package with the necessary fixes and improvements.

examples/minimal-expo/package.json (1)

21-21: LGTM!

The minor version update of the @uploadthing/expo package from 7.0.2 to 7.0.3 aligns with the PR objective. This should introduce bug fixes, improvements, or minor feature additions without breaking changes.

examples/backend-adapters/package.json (1)

27-27: LGTM!

The dependency version update for @uploadthing/react from 7.0.2 to 7.0.3 is appropriate and aligns with the PR objectives. This ensures that the example project uses the latest version of the package with the pluralization fix.

packages/expo/CHANGELOG.md (1)

3-8: Changelog entry looks good!

The changelog entry for version 7.0.3 accurately captures the patch change updating the @uploadthing/react dependency to version 7.0.3. The format is consistent with previous entries, and the linked commit hash provides a helpful reference.

packages/react/CHANGELOG.md (1)

3-7: LGTM!

The changelog entry for version 7.0.3 looks good. It follows the expected format, includes all relevant information, and matches the AI-generated summary.

@@ -8,7 +8,7 @@
"start": "vite preview"
},
"dependencies": {
"@uploadthing/react": "7.0.2",
"@uploadthing/react": "7.0.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the uploadthing dependency version to match @uploadthing/react.

The uploadthing dependency version 7.0.2 does not match the updated @uploadthing/react version 7.0.3. This mismatch might lead to unexpected behavior or errors if there are breaking changes or incompatibilities between the versions.

Apply this diff to update the uploadthing dependency version:

   "dependencies": {
     "@uploadthing/react": "7.0.3",
     "react": "18.3.1",
     "react-dom": "18.3.1",
-    "uploadthing": "7.0.2"
+    "uploadthing": "7.0.3"
   },

Committable suggestion was skipped due to low confidence.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (4)
examples/minimal-nuxt/package.json (1)

12-12: Consider updating @uploadthing/nuxt to match the new version.

While uploadthing has been updated to version 7.0.3, @uploadthing/nuxt is still at version 7.0.2. To ensure consistency and avoid potential compatibility issues, consider updating @uploadthing/nuxt to version 7.0.3 as well.

Here's the suggested change:

-    "@uploadthing/nuxt": "7.0.2",
+    "@uploadthing/nuxt": "7.0.3",
examples/backend-adapters/client-vue/package.json (1)

11-12: Consider updating @uploadthing/vue to match uploadthing version.

While the uploadthing package has been updated to version 7.0.3, the @uploadthing/vue package is still at version 7.0.2. To ensure compatibility and to benefit from any potential improvements, consider updating @uploadthing/vue to version 7.0.3 as well.

Here's the suggested change:

{
  "dependencies": {
-   "@uploadthing/vue": "7.0.2",
+   "@uploadthing/vue": "7.0.3",
    "uploadthing": "7.0.3",
    "vue": "^3.4.21"
  },
}
examples/minimal-solidstart/package.json (1)

17-17: LGTM! Version update is consistent with PR objectives.

The update of the uploadthing package to version 7.0.3 aligns with the release process described in the PR objectives.

However, I noticed that the @uploadthing/solid package is still at version 7.0.2. Consider updating this package as well to maintain consistency across related packages.

packages/uploadthing/CHANGELOG.md (1)

3-7: LGTM! Consider adding more details about the fix.

The changelog entry for version 7.0.3 is clear and concise. It properly documents the fix for the onUploadComplete callback, enforcing a JSONObject return type. The link to the pull request and the credit to the contributor are appreciated.

Consider adding a brief explanation of why this fix was necessary or what issues it prevents. This could provide more context for users upgrading to this version.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b1d7e6d and 9622022.

Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing (28)
  • .changeset/cool-boats-look.md (0 hunks)
  • examples/backend-adapters/client-react/package.json (1 hunks)
  • examples/backend-adapters/client-vanilla/package.json (1 hunks)
  • examples/backend-adapters/client-vue/package.json (1 hunks)
  • examples/backend-adapters/package.json (1 hunks)
  • examples/backend-adapters/server/package.json (1 hunks)
  • examples/minimal-appdir/package.json (1 hunks)
  • examples/minimal-astro-react/package.json (1 hunks)
  • examples/minimal-expo/package.json (2 hunks)
  • examples/minimal-nuxt/package.json (1 hunks)
  • examples/minimal-pagedir/package.json (1 hunks)
  • examples/minimal-solidstart/package.json (1 hunks)
  • examples/minimal-sveltekit/package.json (1 hunks)
  • examples/with-clerk-appdir/package.json (1 hunks)
  • examples/with-clerk-pagesdir/package.json (1 hunks)
  • examples/with-clerk-remix/package.json (1 hunks)
  • examples/with-drizzle-appdir/package.json (1 hunks)
  • examples/with-drizzle-pagesdir/package.json (1 hunks)
  • examples/with-novel/package.json (2 hunks)
  • examples/with-react-image-crop/package.json (1 hunks)
  • examples/with-serveractions/package.json (1 hunks)
  • examples/with-tailwindcss/package.json (1 hunks)
  • packages/expo/CHANGELOG.md (1 hunks)
  • packages/expo/package.json (1 hunks)
  • packages/react/CHANGELOG.md (1 hunks)
  • packages/react/package.json (1 hunks)
  • packages/uploadthing/CHANGELOG.md (1 hunks)
  • packages/uploadthing/package.json (1 hunks)
Files not reviewed due to no reviewable changes (1)
  • .changeset/cool-boats-look.md
Files skipped from review due to trivial changes (2)
  • examples/backend-adapters/server/package.json
  • packages/uploadthing/package.json
Files skipped from review as they are similar to previous changes (17)
  • examples/backend-adapters/client-react/package.json
  • examples/minimal-appdir/package.json
  • examples/minimal-astro-react/package.json
  • examples/minimal-expo/package.json
  • examples/minimal-pagedir/package.json
  • examples/with-clerk-appdir/package.json
  • examples/with-clerk-pagesdir/package.json
  • examples/with-clerk-remix/package.json
  • examples/with-drizzle-appdir/package.json
  • examples/with-drizzle-pagesdir/package.json
  • examples/with-novel/package.json
  • examples/with-react-image-crop/package.json
  • examples/with-tailwindcss/package.json
  • packages/expo/CHANGELOG.md
  • packages/expo/package.json
  • packages/react/CHANGELOG.md
  • packages/react/package.json
Additional comments not posted (9)
examples/backend-adapters/client-vanilla/package.json (1)

12-12: LGTM: Dependency version update aligns with PR objectives.

The update of the uploadthing dependency from version 7.0.2 to 7.0.3 is correct and consistent with the PR objectives. This patch update likely includes the fix for the dropzone label pluralization issue mentioned in the PR summary.

examples/minimal-nuxt/package.json (1)

14-14: LGTM: Version bump for uploadthing package.

The update of the uploadthing package to version 7.0.3 is consistent with the PR objectives for releasing updated packages.

examples/backend-adapters/client-vue/package.json (1)

12-12: LGTM: Version update for uploadthing package.

The update of the uploadthing package to version 7.0.3 is in line with the PR objectives and ensures that this example project uses the latest version of the package.

examples/with-serveractions/package.json (1)

15-15: LGTM: Dependency update aligns with PR objectives.

The update of uploadthing from version 7.0.2 to 7.0.3 is consistent with the PR objectives. This patch update likely includes the fix for the dropzone label pluralization issue.

As this is an example project, it's crucial to ensure it works correctly with the updated dependency. Please run the following commands to verify:

If these commands execute without errors, it indicates that the example project is compatible with the updated uploadthing version.

Verification successful

Dependency version correctly updated to 7.0.3.

The uploadthing dependency in examples/with-serveractions/package.json has been successfully updated to version 7.0.3 as intended.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the example project builds and starts without errors

cd examples/with-serveractions
npm install
npm run build
npm start

Length of output: 287


Script:

#!/bin/bash
# Description: Verify that 'uploadthing' is set to version 7.0.3 in package.json

# Using jq to extract the version
jq '.dependencies.uploadthing' examples/with-serveractions/package.json

Length of output: 79

examples/minimal-sveltekit/package.json (2)

17-17: LGTM: Version update for uploadthing dependency.

The update of the uploadthing dependency from version 7.0.2 to 7.0.3 is in line with the PR objectives. This minor version update likely includes bug fixes or small improvements.


16-17: Consider updating @uploadthing/svelte dependency.

While uploadthing has been updated to version 7.0.3, @uploadthing/svelte is still at version 7.0.2. For consistency, you might want to check if @uploadthing/svelte also needs to be updated to the latest version.

Verification successful

@uploadthing/svelte is up to date. The latest available version is 7.0.2, which is already used in examples/minimal-sveltekit/package.json.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check if there's a newer version of @uploadthing/svelte available

# Test: Check the latest version of @uploadthing/svelte
npm view @uploadthing/svelte version

# Test: List all files containing @uploadthing/svelte dependency
rg --type json '"@uploadthing/svelte":'

Length of output: 227


Script:

#!/bin/bash
# Description: Check the latest version of @uploadthing/svelte available using curl and jq

# Test: Fetch the latest version from npm registry
curl -s https://registry.npmjs.org/@uploadthing/svelte | jq -r '.["dist-tags"].latest'

# Test: List all files containing @uploadthing/svelte dependency
rg --type json '"@uploadthing/svelte":'

Length of output: 212

examples/backend-adapters/package.json (3)

27-27: LGTM: Dependency update for @uploadthing/react

The update of @uploadthing/react to version 7.0.3 is consistent with the PR objectives. This patch update includes the fix for the dropzone label pluralization issue.


Line range hint 1-32: Summary of package.json updates

The changes in this file are minimal and focused:

  1. @uploadthing/react has been updated to version 7.0.3, which addresses the dropzone label pluralization issue.
  2. uploadthing has also been updated to version 7.0.3, though this wasn't explicitly mentioned in the PR objectives.

These updates are likely to improve the functionality of the project without introducing breaking changes, given they are patch version increments. However, it's recommended to run the project's test suite to ensure compatibility with these new versions.


30-30: Verify the update of uploadthing dependency

The uploadthing package has been updated to version 7.0.3. While this aligns with the version update of @uploadthing/react, it wasn't explicitly mentioned in the PR objectives.

Could you please confirm if this update is intentional and necessary? If so, consider updating the PR description to include this change for clarity.

To verify the necessity of this update, you can run the following script:

If the script returns true, it indicates that uploadthing is a peer dependency of @uploadthing/react, justifying this update.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Outside diff range and nitpick comments (2)
packages/vue/CHANGELOG.md (1)

3-10: LGTM! Consider adding more context to the changelog entry.

The changelog entry for version 7.0.3 is clear and concise. It properly documents the removal of the internal dropzone package and the update to the shared dependency.

To improve clarity for users, consider adding a brief explanation of why the internal dropzone package was removed. For example:

 ## 7.0.3

 ### Patch Changes

- [#977](https://github.com/pingdotgg/uploadthing/pull/977) [`2afabe5`](https://github.com/pingdotgg/uploadthing/commit/2afabe59a0e6319ec469eba670b1e3e920f596ee) Thanks [@juliusmarminge](https://github.com/juliusmarminge)! - chore: remove internal dropzone package to prevent peer dependency conflicts between package managers
+ This change aims to simplify the package structure and avoid potential conflicts, improving compatibility across different package managers.

- Updated dependencies [[`2afabe5`](https://github.com/pingdotgg/uploadthing/commit/2afabe59a0e6319ec469eba670b1e3e920f596ee)]:
  - @uploadthing/shared@7.0.3
packages/svelte/CHANGELOG.md (1)

3-10: LGTM! Consider adding more details about the impact.

The changelog entry for version 7.0.3 is well-formatted and includes the necessary information about the changes made. It correctly references the PR, commit, and contributor. The removal of the internal dropzone package to prevent peer dependency conflicts is a good improvement.

Consider adding a brief note about the potential impact of this change on users, such as:

 - [#977](https://github.com/pingdotgg/uploadthing/pull/977) [`2afabe5`](https://github.com/pingdotgg/uploadthing/commit/2afabe59a0e6319ec469eba670b1e3e920f596ee) Thanks [@juliusmarminge](https://github.com/juliusmarminge)! - chore: remove internal dropzone package to prevent peer dependency conflicts between package managers
+  This change should resolve any peer dependency warnings or errors that users may have encountered with different package managers.
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 69ef491 and c34296c.

Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
Files selected for processing (39)
  • .changeset/cool-boats-look.md (0 hunks)
  • .changeset/ten-pillows-smile.md (0 hunks)
  • examples/backend-adapters/client-react/package.json (1 hunks)
  • examples/backend-adapters/client-vanilla/package.json (1 hunks)
  • examples/backend-adapters/client-vue/package.json (1 hunks)
  • examples/backend-adapters/package.json (1 hunks)
  • examples/backend-adapters/server/package.json (1 hunks)
  • examples/minimal-appdir/package.json (1 hunks)
  • examples/minimal-astro-react/package.json (1 hunks)
  • examples/minimal-expo/package.json (2 hunks)
  • examples/minimal-nuxt/package.json (1 hunks)
  • examples/minimal-pagedir/package.json (1 hunks)
  • examples/minimal-solidstart/package.json (1 hunks)
  • examples/minimal-sveltekit/package.json (1 hunks)
  • examples/with-clerk-appdir/package.json (1 hunks)
  • examples/with-clerk-pagesdir/package.json (1 hunks)
  • examples/with-clerk-remix/package.json (1 hunks)
  • examples/with-drizzle-appdir/package.json (1 hunks)
  • examples/with-drizzle-pagesdir/package.json (1 hunks)
  • examples/with-novel/package.json (2 hunks)
  • examples/with-react-image-crop/package.json (1 hunks)
  • examples/with-serveractions/package.json (1 hunks)
  • examples/with-tailwindcss/package.json (1 hunks)
  • packages/expo/CHANGELOG.md (1 hunks)
  • packages/expo/package.json (1 hunks)
  • packages/nuxt/CHANGELOG.md (1 hunks)
  • packages/nuxt/package.json (1 hunks)
  • packages/react/CHANGELOG.md (1 hunks)
  • packages/react/package.json (1 hunks)
  • packages/shared/CHANGELOG.md (1 hunks)
  • packages/shared/package.json (1 hunks)
  • packages/solid/CHANGELOG.md (1 hunks)
  • packages/solid/package.json (1 hunks)
  • packages/svelte/CHANGELOG.md (1 hunks)
  • packages/svelte/package.json (1 hunks)
  • packages/uploadthing/CHANGELOG.md (1 hunks)
  • packages/uploadthing/package.json (1 hunks)
  • packages/vue/CHANGELOG.md (1 hunks)
  • packages/vue/package.json (1 hunks)
Files not reviewed due to no reviewable changes (2)
  • .changeset/cool-boats-look.md
  • .changeset/ten-pillows-smile.md
Files skipped from review due to trivial changes (6)
  • examples/backend-adapters/client-react/package.json
  • packages/nuxt/package.json
  • packages/shared/package.json
  • packages/solid/package.json
  • packages/svelte/package.json
  • packages/vue/package.json
Files skipped from review as they are similar to previous changes (26)
  • examples/backend-adapters/client-vanilla/package.json
  • examples/backend-adapters/client-vue/package.json
  • examples/backend-adapters/package.json
  • examples/backend-adapters/server/package.json
  • examples/minimal-appdir/package.json
  • examples/minimal-astro-react/package.json
  • examples/minimal-expo/package.json
  • examples/minimal-nuxt/package.json
  • examples/minimal-pagedir/package.json
  • examples/minimal-solidstart/package.json
  • examples/minimal-sveltekit/package.json
  • examples/with-clerk-appdir/package.json
  • examples/with-clerk-pagesdir/package.json
  • examples/with-clerk-remix/package.json
  • examples/with-drizzle-appdir/package.json
  • examples/with-drizzle-pagesdir/package.json
  • examples/with-novel/package.json
  • examples/with-react-image-crop/package.json
  • examples/with-serveractions/package.json
  • examples/with-tailwindcss/package.json
  • packages/expo/CHANGELOG.md
  • packages/expo/package.json
  • packages/react/CHANGELOG.md
  • packages/react/package.json
  • packages/uploadthing/CHANGELOG.md
  • packages/uploadthing/package.json
Additional comments not posted (4)
packages/shared/CHANGELOG.md (2)

3-7: LGTM: Changelog entry is well-formatted and informative.

The changelog entry for version 7.0.3 is clear and concise, providing essential information about the patch change, including the pull request number, commit hash, and contributor.


3-7: Verify the impact of removing the internal dropzone package.

While removing the internal dropzone package to prevent peer dependency conflicts is a positive change, it's important to ensure that this modification doesn't inadvertently affect the package's functionality or introduce any new issues.

To verify the impact of this change, you can run the following script:

packages/solid/CHANGELOG.md (2)

3-10: LGTM! Improved package compatibility.

The changes in version 7.0.3 look good:

  1. Removing the internal dropzone package should help prevent peer dependency conflicts between package managers, which is a good practice for maintaining compatibility.
  2. Updating the @uploadthing/shared dependency to version 7.0.3 ensures that the package is using the latest shared utilities and functions.

These changes should lead to better compatibility and fewer conflicts for users of the package.


Line range hint 1-1024: Well-maintained changelog with clear version history.

The changelog for @uploadthing/solid is well-structured and provides a clear history of changes for each version. It effectively communicates the evolution of the package, including major changes, new features, and bug fixes. This level of detail is valuable for users and contributors to understand the package's development over time.

Comment on lines 3 to 8
## 7.0.3

### Patch Changes

- Updated dependencies [[`2afabe5`](https://github.com/pingdotgg/uploadthing/commit/2afabe59a0e6319ec469eba670b1e3e920f596ee)]:
- @uploadthing/vue@7.0.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

@uploadthing/vue dependency in packages/nuxt/package.json is not updated to version 7.0.3.

  • packages/nuxt/package.json: "@uploadthing/vue": "workspace:*",
Analysis chain

LGTM! Changelog entry is correct and consistent with PR objectives.

The new changelog entry for version 7.0.3 is well-formatted and accurately reflects the changes described in the PR objectives. It correctly identifies the update to the @uploadthing/vue dependency to version 7.0.3 as a patch change.

To further verify the consistency of this change across the project, we can run the following script:

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the consistency of the @uploadthing/vue dependency version across the project

# Test 1: Check if the @uploadthing/vue dependency is updated to 7.0.3 in package.json
echo "Checking package.json for @uploadthing/vue version 7.0.3:"
rg '"@uploadthing/vue": "7\.0\.3"' packages/nuxt/package.json

# Test 2: Verify that no other files still reference the old version
echo "Checking for any remaining references to older versions of @uploadthing/vue:"
rg '"@uploadthing/vue": "(?!7\.0\.3)"' -g '!CHANGELOG.md'

Length of output: 669


Script:

#!/bin/bash
# Description: Verify that all references to @uploadthing/vue are updated to version 7.0.3 across the project

# Test 1: Check if the @uploadthing/vue dependency is updated to 7.0.3 in package.json
echo "Checking package.json for @uploadthing/vue version 7.0.3:"
rg '"@uploadthing/vue": "7\.0\.3"' packages/nuxt/package.json

# Test 2: Verify that no other files still reference a different version of @uploadthing/vue
echo "Checking for any remaining references to older versions of @uploadthing/vue:"
rg '"@uploadthing/vue": "[^"]+"' -g '!CHANGELOG.md' | grep -v '"@uploadthing/vue": "7\.0\.3"'

Length of output: 513

@github-actions github-actions bot force-pushed the changeset-release/main branch from c34296c to a4ecc3d Compare September 25, 2024 08:05
@juliusmarminge juliusmarminge merged commit eba5f69 into main Oct 8, 2024
3 checks passed
@juliusmarminge juliusmarminge deleted the changeset-release/main branch October 8, 2024 22:24
This was referenced Oct 24, 2024
@coderabbitai coderabbitai bot mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants