Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unused/unnecessary imports #176

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Clean up unused/unnecessary imports #176

merged 1 commit into from
Jun 13, 2024

Conversation

tianyizheng02
Copy link
Contributor

@tianyizheng02 tianyizheng02 commented Jun 4, 2024

  • Clean up unused imports throughout codebase
  • Replace most type hint imports from typing package with built-in type hints (e.g., List -> list, Optional[str] -> str | None)

My goal with this import cleanup is to prepare the repo for a similar cleanup for the project dependencies: it's harder to tell which packages aren't actually required as dependencies if some packages are imported but never used.

Clean up unused imports throughout codebase and replace most type hint
imports from typing package with built-in type hints (e.g., List -> list)
@tianyizheng02 tianyizheng02 marked this pull request as ready for review June 4, 2024 05:18
@tianyizheng02 tianyizheng02 requested a review from nij-patel June 8, 2024 21:13
Copy link
Member

@nij-patel nij-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m

@nij-patel nij-patel merged commit a9d8aac into dev Jun 13, 2024
1 check passed
@nij-patel nij-patel deleted the clean-up-imports branch June 13, 2024 00:39
This was referenced Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants