change: modify behavior of expressions, interaction between isBinary and override #1489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's about interaction between isBinary and override expressions See the discussion: #1484 Also add a test of VRMExpression to confirm the desired behavior
0b5vr
added a commit
to 0b5vr/vrm-specification
that referenced
this pull request
Sep 6, 2024
…e interacts each other - The original discussion: pixiv/three-vrm#1484 - The implementation example on three-vrm: pixiv/three-vrm#1489 TODO: english translation
This was referenced Oct 21, 2024
0b5vr
changed the title
0b5vr
commented
Oct 21, 2024
| @@ -1,6 +1,7 @@ | |||
| import * as THREE from 'three'; | |||
| import { VRMExpressionBind } from './VRMExpressionBind'; | |||
| import type { VRMExpressionOverrideType } from './VRMExpressionOverrideType'; | |||
| import type { VRMExpressionManager } from './VRMExpressionManager'; | |||
There was a problem hiding this comment.
VRMExpressionManager is only referred from a doc comment
ke456-png
requested changes
Oct 21, 2024
I will update test cases in the next commit See: https://github.com/vrm-c/vrm-specification/blob/master/specification/VRMC_vrm-1.0/expressions.md#expression-specification The suggestion: #1489 Co-authored-by: ke456-png <108649297+ke456-png@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the behavior of expressions.
Related link