wip feat: expressions, clarify the behavior when isBinary and override interacts each other #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e interacts each other - The original discussion: pixiv/three-vrm#1484 - The implementation example on three-vrm: pixiv/three-vrm#1489 TODO: english translation
… and isBinary, reword japanese TODO: english translation
0b5vr
commented
Sep 26, 2024
0b5vr
commented
Sep 26, 2024
…he spec based on MIRO-san's suggestion
…tion also small reword on ja
ousttrue
approved these changes
Oct 11, 2024
This was referenced Oct 21, 2024
ousttrue
added a commit
to ousttrue/UniVRM
that referenced
this pull request
Oct 21, 2024
ousttrue
added a commit
to ousttrue/UniVRM
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
本PRは、未定義動作だった
isBinaryとoverrideBlink等のオーバーライド間の挙動を定義します。isBinaryとoverrideを併用することは妥当と判断し、実際の使用用途を想定しながら尤もらしい挙動としました。