Fix incompatibility with Pillow 10.1+. #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of setting ``image.mode``, we call ``image.convert``. This works in Pillow 9 and 10.
This comment was marked as resolved.
This comment was marked as resolved.
|
@jenkins-plone-org please run jobs |
davisagli
approved these changes
Jan 29, 2024
mauritsvanrees
added a commit
to plone/buildout.coredev
that referenced
this pull request
Jan 29, 2024
This should work, now that plone/plone.scale#90 is merged. I am inclined to say we only do this for Plone 6.1, not 6.0. The release has backwards incompatibilities. Should not be noticeable under normal use, but you never know what projects have as extra code. I am not aware of anything new in Pillow 10 that we would really want to actively use in Plone. So 9.5 should still be fine for Plone 6.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of setting
image.mode, we callimage.convert. This works in Pillow 9 and 10.Fixes #89.