Devtools/main #206
Merged
Devtools/main #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b637701.
1) Chromium has runtime checks that intentionally crash chromium in fear of security vulnerabilities. 2) Chromium does not remove old and degrading APIs from their documentation, they do not work. 3) Chromium will flesh out API structures and header files and half-implement the concept, that is: Stuff they are not using is buggy, it is NOT enough for it to be part of the spec. 4) Using DevTools Protocol from w/in Chromium uses their SimpleDevToolsProtocolClient class, which is _not_ complete. 5) Because there is no message broker between the Host and Client, SimpleDevToolsProtocolClient sends json instructions as arguments directly to the host consumer- the browser or the tab. 6) Because of above checks in #1, calls to class methods must often originate from the exact same thread that the class was instantiated on, or there will be a mandatory fatal crash. 7) SimpleDevToolsProtocol client does not handle this. 8) And in general, generating and using tabs with SimpleDevToolsProtocol.CreateSession will cause crashes due to checks due to the above when any command is sent. 9) Chromium's own workarounds include using APIs that we're just not supposed to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.