Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtools/main #206

Merged
merged 521 commits into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from 250 commits
Commits
Show all changes
521 commits
Select commit Hold shift + click to select a range
fe4fc77
Add 12-roll_wheel
ayjayt Jul 21, 2024
a6f0b3a
Make room from 11-extract_etc.sh
ayjayt Jul 22, 2024
ed8ce7c
Factor out extract_etc and fix up directories
ayjayt Jul 22, 2024
229e32f
Fix some typos in 10-extract
ayjayt Jul 22, 2024
4e2db30
Fix mathjax path
ayjayt Jul 22, 2024
d71d97f
Fix font extracting dictionary
ayjayt Jul 22, 2024
31f7a58
Prepare setup.py for roll_wheel
ayjayt Jul 22, 2024
7976d19
Prepare setup.py for roll_wheel
ayjayt Jul 22, 2024
42d43d5
Include pip in install deps
ayjayt Jul 22, 2024
81d192f
Refine a bit packaging process
ayjayt Jul 22, 2024
847dfca
Fix up directory typos
ayjayt Jul 22, 2024
09e9dd5
Fix pathing for package_data
ayjayt Jul 22, 2024
ee3c58a
Finish last commit's errors
ayjayt Jul 22, 2024
2f34a7e
Fix package_data pathing issues + test
ayjayt Jul 22, 2024
29d1db5
Flip pure build flag because we have c++
ayjayt Jul 22, 2024
67257bb
Fix bad parens
ayjayt Jul 22, 2024
b637701
Remove us handling stderr
ayjayt Jul 23, 2024
d99e9ac
Revert "Remove us handling stderr"
ayjayt Jul 23, 2024
27d7df8
Skip docker image pull error
ayjayt Jul 23, 2024
68ad981
Move into incognito mode
ayjayt Jul 23, 2024
7714007
Move IsExEInPath to new version
ayjayt Jul 23, 2024
1c55843
Merge in scopes
ayjayt Jul 23, 2024
0e37829
Add scopes to main build config
ayjayt Jul 23, 2024
9d92d71
Add primeTab function to dispatch
ayjayt Jul 23, 2024
25f1d78
Fix up some memory shenanigans
ayjayt Jul 23, 2024
9a6d384
Fix a variety of compile errors
ayjayt Jul 23, 2024
ce3ef7f
Incredible, incredible butchery:
ayjayt Jul 23, 2024
64d2a48
Organize and renable
ayjayt Jul 23, 2024
7981078
Reintegrate job queue
ayjayt Jul 23, 2024
5a04a03
Process export directive in old style
ayjayt Jul 24, 2024
972fec3
Some build changes
ayjayt Jul 24, 2024
13d203e
Some build changes2
ayjayt Jul 24, 2024
ba1ae81
Add setuptools to import
ayjayt Jul 24, 2024
ec921b7
Add logic to handle old protocol
ayjayt Jul 24, 2024
104eea5
Add debug option for kaleido py
ayjayt Jul 24, 2024
cd0ac13
Make tab dispatch + job/tab queue
ayjayt Jul 24, 2024
511a66b
Use new API
ayjayt Jul 24, 2024
3c77b50
Ignore stderr if dumping it anyway
ayjayt Jul 24, 2024
927d088
Add placeholder to avoid destructor off thread
ayjayt Jul 24, 2024
6a76ca0
Augment python with cleaner shutdown
ayjayt Jul 24, 2024
e5da820
Remove tempfile at shutdown
ayjayt Jul 24, 2024
35237d5
Attempt to add and remove handlers
ayjayt Jul 24, 2024
dde0796
Get information about prereq exes
ayjayt Jul 24, 2024
5574016
Add checks for other formats
ayjayt Jul 24, 2024
cd40a84
Move in format validation
ayjayt Jul 24, 2024
d739424
Events fire once
ayjayt Jul 24, 2024
1eefcbf
Clean up notes
ayjayt Jul 24, 2024
3d98aeb
Load all scripts
ayjayt Jul 24, 2024
2f4e407
Shore up debugging and error printing
ayjayt Jul 24, 2024
79d263d
Transfer whole spec with job
ayjayt Jul 24, 2024
8ff9d79
Collect env vars and cwd in python, not bash
ayjayt Jul 24, 2024
5ce9de4
Clear some memory before exit
ayjayt Jul 24, 2024
a86af49
Remove danglin pointer
ayjayt Jul 24, 2024
907e7a6
Fix comments
ayjayt Jul 24, 2024
a2306b2
Build function runner
ayjayt Jul 24, 2024
f8506fd
Change scope.BuildCallArguments to new api
ayjayt Jul 25, 2024
199eab8
Fix up move semantics
ayjayt Jul 25, 2024
fcf2d01
Fix syntax error
ayjayt Jul 25, 2024
7796968
Fix bad iterator
ayjayt Jul 25, 2024
1ed78d5
Make devtools aware of promise
ayjayt Jul 25, 2024
21beb1d
Add techdebt description
ayjayt Jul 25, 2024
de227fe
Add more debugging info to js
ayjayt Jul 25, 2024
edaf5c6
Pass spec as json-like, not json-string
ayjayt Jul 25, 2024
d96bfd4
Add process image and close job tasks
ayjayt Jul 25, 2024
97e93e0
Retab, organize, and comment
ayjayt Jul 25, 2024
7c73744
Fix method access
ayjayt Jul 25, 2024
1693edb
Clean up logging and notes
ayjayt Jul 25, 2024
69a7637
Fix check_errors access
ayjayt Jul 25, 2024
5765fd4
Add to script loop to copy libs
ayjayt Jul 25, 2024
62f6e2d
Make pure pylib again
ayjayt Jul 25, 2024
ce106c6
Try removing devtools client
ayjayt Jul 25, 2024
9e7453e
Give temporary name
ayjayt Jul 25, 2024
a1daa11
Add some more mease to the extract
ayjayt Jul 25, 2024
e8eb035
Remove debugging symbols from output
ayjayt Jul 25, 2024
37e4ddf
Remove printing
ayjayt Jul 25, 2024
5c84c80
Revert "Remove printing"
ayjayt Jul 28, 2024
f9c4365
Change default to production build
ayjayt Jul 28, 2024
f028de6
Add windows build artifacts to gitignore
ayjayt Jul 29, 2024
235e9b5
Fix 02, 03 to use cmd.exe in windows
ayjayt Jul 29, 2024
b4b7993
Eliminate old readme
ayjayt Jul 29, 2024
dd5363a
Add patch to fix version.py for windows
ayjayt Jul 29, 2024
0c0804c
Safety-escape character
ayjayt Jul 29, 2024
4d1505d
Adjust for windows
ayjayt Jul 29, 2024
2272bca
Fix up some syntax
ayjayt Jul 29, 2024
50c7146
Modify build flags
ayjayt Jul 30, 2024
1d91134
Add cpus to env vars in cmd.exe
ayjayt Jul 30, 2024
2bcf56c
Improve verbosity
ayjayt Jul 30, 2024
e8d0202
Make 09 for windows
ayjayt Jul 30, 2024
28d2e60
Add notes to TECHDEBT
ayjayt Jul 30, 2024
0a9a22d
Set up potential mac build
ayjayt Jul 30, 2024
f9d3b43
Remove double define
ayjayt Jul 30, 2024
c369fcc
Fix namespaces for OS_WIN
ayjayt Jul 30, 2024
d1f3b84
fix: use /usr/bin/env to find bash (#203)
ayjayt Jul 30, 2024
c114d90
Merge branch 'andrew/win-package' into andrew/mac-build
ayjayt Jul 30, 2024
9b5fbf1
Add use_cups to mac buildflag
ayjayt Jul 30, 2024
0803dad
Remove deprecated tempfile function
ayjayt Jul 30, 2024
a916538
Use google's raw_ptr not *
ayjayt Jul 30, 2024
29fbeab
Exhcange c string for std::string in tmpfile
ayjayt Jul 30, 2024
8d5430d
Reset destructor for tmpfile
ayjayt Jul 30, 2024
09c07e8
Reset destructor for tmpfile2
ayjayt Jul 30, 2024
13aca2f
Add stdlib for non-win builds
ayjayt Jul 30, 2024
6d6b4cc
Remove typo
ayjayt Jul 30, 2024
ce3f4c6
Remove platform specific guard
ayjayt Jul 30, 2024
19d6ddb
stdlib-->unistd
ayjayt Jul 30, 2024
3fa5c0c
Remove all posix use base:: for tmpfile
ayjayt Jul 30, 2024
61ddc3a
Retype from base:: tmpfile utils
ayjayt Jul 30, 2024
143fce4
Wrangle with FILE-->File
ayjayt Jul 30, 2024
27c4a9c
Try ofstream convesion
ayjayt Jul 30, 2024
294372e
Wrap up new API wrangling
ayjayt Jul 30, 2024
7591669
Readd destructor
ayjayt Jul 30, 2024
506144e
Use base:: xplatform DeleteFile
ayjayt Jul 30, 2024
fae74be
Aggressively narrow wstring to sring
ayjayt Jul 30, 2024
3294370
Add to TECHDEBT.md
ayjayt Jul 30, 2024
f256ede
Fix some windows things:
ayjayt Jul 30, 2024
9a15589
Mk builddir
ayjayt Jul 30, 2024
17cae13
Add packaging artifacts to .gitignore
ayjayt Jul 31, 2024
8ca34cd
Amp verbosity in 10-extract
ayjayt Jul 31, 2024
a19e5b7
Amp verbosity in 10-extract2
ayjayt Jul 31, 2024
ee10c3b
Amp verbosity in 10-extract-3
ayjayt Jul 31, 2024
e967849
Amp verbosity in 10-extract X 4
ayjayt Jul 31, 2024
b2b1218
Clarify comment
ayjayt Jul 31, 2024
5fda465
Improve verbosity in 11, 12, and 13 scripts
ayjayt Jul 31, 2024
e92956b
Update lockfile
ayjayt Jul 31, 2024
2e77b0e
Properly delimit vars for OSX
ayjayt Jul 31, 2024
8cb409f
Obsess over ENV VAR delimiter {}
ayjayt Jul 31, 2024
efc8d06
Add check for config file in 10-extract
ayjayt Jul 31, 2024
30c6686
Remove debug reminder
ayjayt Jul 31, 2024
f4f4fe7
Add more delimiting variables
ayjayt Jul 31, 2024
39d4232
Some IFS magic to deal w/ spaces in filenames
ayjayt Jul 31, 2024
59e263e
Fix suffix in config file
ayjayt Jul 31, 2024
21e21d6
Fix string in readlink
ayjayt Jul 31, 2024
a3da270
Fix string in readlink x 2
ayjayt Jul 31, 2024
5f1dd1b
Fix string in readlink x 3
ayjayt Jul 31, 2024
49eb572
Unify copy/dir strategy in 10-extract
ayjayt Jul 31, 2024
2a3572b
Unify copy/dir strategy in 10-extract x 2
ayjayt Jul 31, 2024
15b247e
Add commit print to utilities to see version
ayjayt Jul 31, 2024
9af5ead
remove -m from readlink
ayjayt Jul 31, 2024
0c331f7
Add -f to readlink for canonicalize
ayjayt Jul 31, 2024
5274930
Start removing readlink
ayjayt Jul 31, 2024
056159e
Start removing readlink x 2
ayjayt Jul 31, 2024
b14380a
Start removing readlink x 3
ayjayt Jul 31, 2024
4fce021
Start removing readlink x 4
ayjayt Jul 31, 2024
29b9004
Start removing readlink x 5
ayjayt Jul 31, 2024
0d7b4c4
Start removing readlink x 6
ayjayt Jul 31, 2024
d96fd9a
Start removing readlink x 7
ayjayt Jul 31, 2024
7bf72ba
Start removing readlink x 8
ayjayt Jul 31, 2024
62e762f
Start removing readlink x 9
ayjayt Jul 31, 2024
b998da8
Start removing readlink x 10
ayjayt Jul 31, 2024
3feb790
Start removing readlink x 11
ayjayt Jul 31, 2024
9fa3aa7
Start removing readlink x 12
ayjayt Jul 31, 2024
ee04939
Use cp solution for 10-extract
ayjayt Jul 31, 2024
d15fea0
Set config pathname as actual path from start
ayjayt Jul 31, 2024
ab466c9
Reinsert old example
ayjayt Jul 31, 2024
8b27c2c
Reinsert old example x 2
ayjayt Jul 31, 2024
2797d99
Frankenstein patch headless shell
ayjayt Jul 31, 2024
c708023
Remove debugging prints
ayjayt Jul 31, 2024
a796075
Change .cmd to .exe
ayjayt Jul 31, 2024
6dbfe03
add -p to mkdir
ayjayt Jul 31, 2024
ca3a0ee
Remove accidental indent
ayjayt Aug 1, 2024
0de9fc4
Remove test function
ayjayt Aug 1, 2024
c2e6d6f
Add debug logs
ayjayt Aug 1, 2024
2eccbb9
Add more debugging
ayjayt Aug 1, 2024
9553e9a
Modify tmp file algo to control name
ayjayt Aug 1, 2024
75c0248
Use other wide URL function
ayjayt Aug 1, 2024
83c6a62
Improve debugging output
ayjayt Aug 1, 2024
fd468f1
Catch js exceptions
ayjayt Aug 1, 2024
af8c96c
Return error to kaleido.py
ayjayt Aug 1, 2024
b4b470b
Add switch for char to wchar
ayjayt Aug 1, 2024
88dba70
Add append for win
ayjayt Aug 1, 2024
fc85f16
Merge branch 'andrew/mac-build' into andrew/windows_restructure
ayjayt Aug 1, 2024
957ab3a
Fix indents in circleci
ayjayt Aug 21, 2024
a01bd89
Merge branch 'master' into andrew/refactor_concurrency
ayjayt Sep 30, 2024
d788316
Add .venv to gitignore
ayjayt Sep 30, 2024
c95e24d
Shorten license since no chrome anymore
ayjayt Sep 30, 2024
b1d1a08
Remove all unnecesary files
ayjayt Sep 30, 2024
7892848
Update README.md for devtools
ayjayt Sep 30, 2024
d8b458c
Convert setup.py to pyproject.toml
ayjayt Sep 30, 2024
f303a4b
Fix typo in README.md
ayjayt Sep 30, 2024
364f3ec
Fix up continuous integration
ayjayt Oct 1, 2024
9ea2c6c
Fix GHA directives for kaleido
ayjayt Oct 1, 2024
8278cf1
Set -x on base.py (?):
ayjayt Oct 8, 2024
5b01908
Excise old kaleido
ayjayt Oct 8, 2024
ffa9b05
Add vendor to package
ayjayt Oct 8, 2024
2a46cf1
Add dist/build to gitignore
ayjayt Oct 8, 2024
ca56ceb
Move issues file
ayjayt Oct 8, 2024
41df98e
Add issue #4 - improper version number- to ISSUES
ayjayt Oct 8, 2024
234fa35
Fix up GHA
ayjayt Oct 8, 2024
22c54bc
Remove unused imports
ayjayt Oct 8, 2024
6b5e33e
Move kaleido to src:
ayjayt Oct 8, 2024
4adb1f8
Add versioning dep to toml
ayjayt Oct 8, 2024
667ad9f
Reorganize for pyproject.toml
ayjayt Oct 8, 2024
d72b9ff
Reorganize namespace to match old api
ayjayt Oct 8, 2024
4bdb8d2
Add issue #6
ayjayt Oct 8, 2024
8cd8df3
Fix spec formatting
ayjayt Oct 8, 2024
fde6c7b
Improve error handling of bad js
ayjayt Oct 8, 2024
a703d25
Vendor js build
ayjayt Oct 8, 2024
4b9304d
Shim over old API's internal shutdown
ayjayt Oct 8, 2024
eb35746
Add issue in TOOD
ayjayt Oct 8, 2024
1758414
Update dependency to choreographer
ayjayt Oct 17, 2024
8586067
Change import from devtools to choreographer
ayjayt Oct 17, 2024
0a7d76e
Change headless to True
ayjayt Oct 17, 2024
cbeb08f
Fix result access to ensure text formats
ayjayt Oct 17, 2024
115b32e
Temporary disable pdf and eps
ayjayt Oct 17, 2024
c594c14
Remove issues
ayjayt Oct 17, 2024
2ce8e8c
Block use of old API w/ asyncio
ayjayt Oct 17, 2024
f812265
Remove unused import
ayjayt Oct 17, 2024
26d8c6a
Vendor mathjax
ayjayt Oct 21, 2024
5437769
Fix mathjax vendor and include by default
ayjayt Oct 21, 2024
4dcef43
Include topojson by default
ayjayt Oct 21, 2024
7605afb
Add topojson/mapboxtoken args to plotlyscopes
ayjayt Oct 21, 2024
76fbc60
docs: update README and LICENSE and add code of conduct (#208)
gvwilson Oct 21, 2024
110da7a
Commit vendored subdirs
ayjayt Oct 21, 2024
2c33620
Change mathjax vendor strategy
ayjayt Oct 21, 2024
c26ea7e
Merge remote-tracking branch 'refs/remotes/origin/devtools/main' into…
ayjayt Oct 21, 2024
97513dd
Remove debug messages
ayjayt Oct 21, 2024
cd8060f
Fix vendor + tempfiles:
ayjayt Oct 22, 2024
0b6114d
Set headless=True
ayjayt Oct 22, 2024
a701db2
Re-enable pdf printing
ayjayt Oct 22, 2024
504f65a
Enable concurrent use of old api w/ active asyncio
ayjayt Oct 24, 2024
f9964d2
Lint: remove unused dep
ayjayt Oct 24, 2024
677c271
Allow plotly.scope to pass debug
ayjayt Oct 24, 2024
54685ac
Upgrade to choreographer 0.99.2
ayjayt Oct 25, 2024
597f9f8
Add debug printing everywhere
ayjayt Oct 28, 2024
ca3e535
Add debug function to get window status during debug
ayjayt Oct 28, 2024
cae9d54
Improve js debug + fix typo there
ayjayt Oct 28, 2024
cb72d4f
Bump dependency
ayjayt Oct 28, 2024
341a0bc
Improve js logger
ayjayt Oct 28, 2024
27bade3
Add pdf features to async template
ayjayt Oct 29, 2024
7403d53
Organize command order
ayjayt Oct 29, 2024
6617f6f
Add timeout option to to_image
ayjayt Oct 29, 2024
cc029d0
Add timeout to deps
ayjayt Oct 30, 2024
a455768
Change temporary directory path
ayjayt Nov 1, 2024
4e2696e
Simplify choreographer commands
ayjayt Nov 1, 2024
d40b984
Add better error handling
ayjayt Nov 1, 2024
70d4368
Move all debug to stderr
ayjayt Nov 1, 2024
e2b31f9
Add method of injecting debug to old api
ayjayt Nov 1, 2024
b2d29da
Add manual test
ayjayt Nov 1, 2024
b2f5c3a
Bump choreo version dep
ayjayt Nov 1, 2024
ce8b8c5
Make js error reporter clearer for searching
ayjayt Nov 4, 2024
6acbf53
Add more vendor to pyproject
ayjayt Nov 4, 2024
db47113
Port html changes from ~2 commits to dyn html
ayjayt Nov 4, 2024
0ba181c
Transfer debug value more reliably
ayjayt Nov 4, 2024
cdd0be3
Zip test results in manual.py
ayjayt Nov 4, 2024
0e5f887
Improve test verbosity
ayjayt Nov 4, 2024
d1201c3
Add test-results to gitignore
ayjayt Nov 5, 2024
0689bfd
Add _ option to env var since - not compat
ayjayt Nov 6, 2024
0493d3d
Revert debug_browser back to debug, not stderr
ayjayt Nov 7, 2024
a8f7a56
Allow setting of kaleido tmpdir
ayjayt Nov 14, 2024
a442da8
Permeate tmp_path in kaledio to choreo.Browser
ayjayt Nov 14, 2024
a20db83
Bump choreo dep to 0.99.6
ayjayt Nov 14, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
416 changes: 0 additions & 416 deletions .circleci/config.yml

This file was deleted.

2 changes: 0 additions & 2 deletions .dockerignore

This file was deleted.

10 changes: 10 additions & 0 deletions .github/workflows/ruff.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
name: ruff-wf
on: pull_request
jobs:
ruff:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: chartboost/ruff-action@v1
with:
src: './src/py'
39 changes: 39 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: test-wf
on: pull_request
jobs:
test-linux:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v1
- name: Install Dependencies
run: sudo apt-get update && sudo apt-get install chromium-browser
- name: Install kaleido
run: ls && pip install src/py/.[dev]
- name: test
run: pytest
timeout-minutes: 1
test-windows:
runs-on: windows-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- name: Install Dependencies
run: choco install googlechrome -y --ignore-checksums
- name: Install kaleido
run: pip install src/py/.[dev]
- name: test
run: pytest
timeout-minutes: 1
test-mac:
runs-on: macos-latest
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
- name: Install Dependencies
run: brew install google-chrome
- name: Install kaleido
run: pip install src/py/.[dev]
- name: test
run: pytest
timeout-minutes: 1
41 changes: 12 additions & 29 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,32 +1,15 @@
repos/CREDITS.html
repos/src
repos/depot_tools
*.DS_Store
*.kate-swp
repos/.cipd/
repos/.gclient_entries
repos/.idea
repos/build
repos/cmake-build-debug
repos/kaleido/js/node_modules
repos/kaleido/js/build
repos/kaleido/version
repos/kaleido/LICENSE.txt
repos/kaleido/README.md
repos/kaleido/py/LICENSE.txt
repos/kaleido/py/README.md
repos/kaleido/py/tests/baselines/plotly/failed
repos/kaleido/artifacts
repos/kaleido/kaleido_artifacts*.zip
# Py Build Stuff
*.pyc
win_toolchain/*.zip
repos/kaleido/py/kaleido/executable
repos/kaleido/py/kaleido/_version.py
repos/kaleido/py/build/
repos/kaleido/py/dist/
*.egg-info/
repos/kaleido/py/scratch/
.idea/
repos/CREDITS.html
repos/*.tar.gz
__pycache__

# Text Editor Stuff
*.DS_Store
*.kate-swp
*.sw*

# Local Environment
.venv

# Artifacts from Build
src/js/build
79 changes: 0 additions & 79 deletions BUILD_AND_RELEASE.md

This file was deleted.

12 changes: 12 additions & 0 deletions ISSUES
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
- [ ] #1: Vendor mathjax
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this file and move issues into the repo (?)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i was afraid of them getting lost in the github tho lol, but yeah

- [ ] #2: Add switch deprecation warnings (See TODO)
- [ ] #3: TODO: Obey plolty versions switches (plotlyjs, mathjax, openmapbox)
- [x] #4: Build not picking up version tag :-( <-- not picking up repo at all
- [x] #5: Can't import
- [ ] #6: Will permanently need more from old api (prepare spec)
- [ ] #7: Move over more from devtools?



NOTES:
Eliminated conda search for mathjax, they can use a custom path
Loading
Loading