-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devtools/main #206
Merged
Merged
Devtools/main #206
Changes from 250 commits
Commits
Show all changes
521 commits
Select commit
Hold shift + click to select a range
fe4fc77
Add 12-roll_wheel
ayjayt a6f0b3a
Make room from 11-extract_etc.sh
ayjayt ed8ce7c
Factor out extract_etc and fix up directories
ayjayt 229e32f
Fix some typos in 10-extract
ayjayt 4e2db30
Fix mathjax path
ayjayt d71d97f
Fix font extracting dictionary
ayjayt 31f7a58
Prepare setup.py for roll_wheel
ayjayt 7976d19
Prepare setup.py for roll_wheel
ayjayt 42d43d5
Include pip in install deps
ayjayt 81d192f
Refine a bit packaging process
ayjayt 847dfca
Fix up directory typos
ayjayt 09e9dd5
Fix pathing for package_data
ayjayt ee3c58a
Finish last commit's errors
ayjayt 2f34a7e
Fix package_data pathing issues + test
ayjayt 29d1db5
Flip pure build flag because we have c++
ayjayt 67257bb
Fix bad parens
ayjayt b637701
Remove us handling stderr
ayjayt d99e9ac
Revert "Remove us handling stderr"
ayjayt 27d7df8
Skip docker image pull error
ayjayt 68ad981
Move into incognito mode
ayjayt 7714007
Move IsExEInPath to new version
ayjayt 1c55843
Merge in scopes
ayjayt 0e37829
Add scopes to main build config
ayjayt 9d92d71
Add primeTab function to dispatch
ayjayt 25f1d78
Fix up some memory shenanigans
ayjayt 9a6d384
Fix a variety of compile errors
ayjayt ce3ef7f
Incredible, incredible butchery:
ayjayt 64d2a48
Organize and renable
ayjayt 7981078
Reintegrate job queue
ayjayt 5a04a03
Process export directive in old style
ayjayt 972fec3
Some build changes
ayjayt 13d203e
Some build changes2
ayjayt ba1ae81
Add setuptools to import
ayjayt ec921b7
Add logic to handle old protocol
ayjayt 104eea5
Add debug option for kaleido py
ayjayt cd0ac13
Make tab dispatch + job/tab queue
ayjayt 511a66b
Use new API
ayjayt 3c77b50
Ignore stderr if dumping it anyway
ayjayt 927d088
Add placeholder to avoid destructor off thread
ayjayt 6a76ca0
Augment python with cleaner shutdown
ayjayt e5da820
Remove tempfile at shutdown
ayjayt 35237d5
Attempt to add and remove handlers
ayjayt dde0796
Get information about prereq exes
ayjayt 5574016
Add checks for other formats
ayjayt cd40a84
Move in format validation
ayjayt d739424
Events fire once
ayjayt 1eefcbf
Clean up notes
ayjayt 3d98aeb
Load all scripts
ayjayt 2f4e407
Shore up debugging and error printing
ayjayt 79d263d
Transfer whole spec with job
ayjayt 8ff9d79
Collect env vars and cwd in python, not bash
ayjayt 5ce9de4
Clear some memory before exit
ayjayt a86af49
Remove danglin pointer
ayjayt 907e7a6
Fix comments
ayjayt a2306b2
Build function runner
ayjayt f8506fd
Change scope.BuildCallArguments to new api
ayjayt 199eab8
Fix up move semantics
ayjayt fcf2d01
Fix syntax error
ayjayt 7796968
Fix bad iterator
ayjayt 1ed78d5
Make devtools aware of promise
ayjayt 21beb1d
Add techdebt description
ayjayt de227fe
Add more debugging info to js
ayjayt edaf5c6
Pass spec as json-like, not json-string
ayjayt d96bfd4
Add process image and close job tasks
ayjayt 97e93e0
Retab, organize, and comment
ayjayt 7c73744
Fix method access
ayjayt 1693edb
Clean up logging and notes
ayjayt 69a7637
Fix check_errors access
ayjayt 5765fd4
Add to script loop to copy libs
ayjayt 62f6e2d
Make pure pylib again
ayjayt ce106c6
Try removing devtools client
ayjayt 9e7453e
Give temporary name
ayjayt a1daa11
Add some more mease to the extract
ayjayt e8eb035
Remove debugging symbols from output
ayjayt 37e4ddf
Remove printing
ayjayt 5c84c80
Revert "Remove printing"
ayjayt f9c4365
Change default to production build
ayjayt f028de6
Add windows build artifacts to gitignore
ayjayt 235e9b5
Fix 02, 03 to use cmd.exe in windows
ayjayt b4b7993
Eliminate old readme
ayjayt dd5363a
Add patch to fix version.py for windows
ayjayt 0c0804c
Safety-escape character
ayjayt 4d1505d
Adjust for windows
ayjayt 2272bca
Fix up some syntax
ayjayt 50c7146
Modify build flags
ayjayt 1d91134
Add cpus to env vars in cmd.exe
ayjayt 2bcf56c
Improve verbosity
ayjayt e8d0202
Make 09 for windows
ayjayt 28d2e60
Add notes to TECHDEBT
ayjayt 0a9a22d
Set up potential mac build
ayjayt f9d3b43
Remove double define
ayjayt c369fcc
Fix namespaces for OS_WIN
ayjayt d1f3b84
fix: use /usr/bin/env to find bash (#203)
ayjayt c114d90
Merge branch 'andrew/win-package' into andrew/mac-build
ayjayt 9b5fbf1
Add use_cups to mac buildflag
ayjayt 0803dad
Remove deprecated tempfile function
ayjayt a916538
Use google's raw_ptr not *
ayjayt 29fbeab
Exhcange c string for std::string in tmpfile
ayjayt 8d5430d
Reset destructor for tmpfile
ayjayt 09c07e8
Reset destructor for tmpfile2
ayjayt 13aca2f
Add stdlib for non-win builds
ayjayt 6d6b4cc
Remove typo
ayjayt ce3f4c6
Remove platform specific guard
ayjayt 19d6ddb
stdlib-->unistd
ayjayt 3fa5c0c
Remove all posix use base:: for tmpfile
ayjayt 61ddc3a
Retype from base:: tmpfile utils
ayjayt 143fce4
Wrangle with FILE-->File
ayjayt 27c4a9c
Try ofstream convesion
ayjayt 294372e
Wrap up new API wrangling
ayjayt 7591669
Readd destructor
ayjayt 506144e
Use base:: xplatform DeleteFile
ayjayt fae74be
Aggressively narrow wstring to sring
ayjayt 3294370
Add to TECHDEBT.md
ayjayt f256ede
Fix some windows things:
ayjayt 9a15589
Mk builddir
ayjayt 17cae13
Add packaging artifacts to .gitignore
ayjayt 8ca34cd
Amp verbosity in 10-extract
ayjayt a19e5b7
Amp verbosity in 10-extract2
ayjayt ee10c3b
Amp verbosity in 10-extract-3
ayjayt e967849
Amp verbosity in 10-extract X 4
ayjayt b2b1218
Clarify comment
ayjayt 5fda465
Improve verbosity in 11, 12, and 13 scripts
ayjayt e92956b
Update lockfile
ayjayt 2e77b0e
Properly delimit vars for OSX
ayjayt 8cb409f
Obsess over ENV VAR delimiter {}
ayjayt efc8d06
Add check for config file in 10-extract
ayjayt 30c6686
Remove debug reminder
ayjayt f4f4fe7
Add more delimiting variables
ayjayt 39d4232
Some IFS magic to deal w/ spaces in filenames
ayjayt 59e263e
Fix suffix in config file
ayjayt 21e21d6
Fix string in readlink
ayjayt a3da270
Fix string in readlink x 2
ayjayt 5f1dd1b
Fix string in readlink x 3
ayjayt 49eb572
Unify copy/dir strategy in 10-extract
ayjayt 2a3572b
Unify copy/dir strategy in 10-extract x 2
ayjayt 15b247e
Add commit print to utilities to see version
ayjayt 9af5ead
remove -m from readlink
ayjayt 0c331f7
Add -f to readlink for canonicalize
ayjayt 5274930
Start removing readlink
ayjayt 056159e
Start removing readlink x 2
ayjayt b14380a
Start removing readlink x 3
ayjayt 4fce021
Start removing readlink x 4
ayjayt 29b9004
Start removing readlink x 5
ayjayt 0d7b4c4
Start removing readlink x 6
ayjayt d96fd9a
Start removing readlink x 7
ayjayt 7bf72ba
Start removing readlink x 8
ayjayt 62e762f
Start removing readlink x 9
ayjayt b998da8
Start removing readlink x 10
ayjayt 3feb790
Start removing readlink x 11
ayjayt 9fa3aa7
Start removing readlink x 12
ayjayt ee04939
Use cp solution for 10-extract
ayjayt d15fea0
Set config pathname as actual path from start
ayjayt ab466c9
Reinsert old example
ayjayt 8b27c2c
Reinsert old example x 2
ayjayt 2797d99
Frankenstein patch headless shell
ayjayt c708023
Remove debugging prints
ayjayt a796075
Change .cmd to .exe
ayjayt 6dbfe03
add -p to mkdir
ayjayt ca3a0ee
Remove accidental indent
ayjayt 0de9fc4
Remove test function
ayjayt c2e6d6f
Add debug logs
ayjayt 2eccbb9
Add more debugging
ayjayt 9553e9a
Modify tmp file algo to control name
ayjayt 75c0248
Use other wide URL function
ayjayt 83c6a62
Improve debugging output
ayjayt fd468f1
Catch js exceptions
ayjayt af8c96c
Return error to kaleido.py
ayjayt b4b470b
Add switch for char to wchar
ayjayt 88dba70
Add append for win
ayjayt fc85f16
Merge branch 'andrew/mac-build' into andrew/windows_restructure
ayjayt 957ab3a
Fix indents in circleci
ayjayt a01bd89
Merge branch 'master' into andrew/refactor_concurrency
ayjayt d788316
Add .venv to gitignore
ayjayt c95e24d
Shorten license since no chrome anymore
ayjayt b1d1a08
Remove all unnecesary files
ayjayt 7892848
Update README.md for devtools
ayjayt d8b458c
Convert setup.py to pyproject.toml
ayjayt f303a4b
Fix typo in README.md
ayjayt 364f3ec
Fix up continuous integration
ayjayt 9ea2c6c
Fix GHA directives for kaleido
ayjayt 8278cf1
Set -x on base.py (?):
ayjayt 5b01908
Excise old kaleido
ayjayt ffa9b05
Add vendor to package
ayjayt 2a46cf1
Add dist/build to gitignore
ayjayt ca56ceb
Move issues file
ayjayt 41df98e
Add issue #4 - improper version number- to ISSUES
ayjayt 234fa35
Fix up GHA
ayjayt 22c54bc
Remove unused imports
ayjayt 6b5e33e
Move kaleido to src:
ayjayt 4adb1f8
Add versioning dep to toml
ayjayt 667ad9f
Reorganize for pyproject.toml
ayjayt d72b9ff
Reorganize namespace to match old api
ayjayt 4bdb8d2
Add issue #6
ayjayt 8cd8df3
Fix spec formatting
ayjayt fde6c7b
Improve error handling of bad js
ayjayt a703d25
Vendor js build
ayjayt 4b9304d
Shim over old API's internal shutdown
ayjayt eb35746
Add issue in TOOD
ayjayt 1758414
Update dependency to choreographer
ayjayt 8586067
Change import from devtools to choreographer
ayjayt 0a7d76e
Change headless to True
ayjayt cbeb08f
Fix result access to ensure text formats
ayjayt 115b32e
Temporary disable pdf and eps
ayjayt c594c14
Remove issues
ayjayt 2ce8e8c
Block use of old API w/ asyncio
ayjayt f812265
Remove unused import
ayjayt 26d8c6a
Vendor mathjax
ayjayt 5437769
Fix mathjax vendor and include by default
ayjayt 4dcef43
Include topojson by default
ayjayt 7605afb
Add topojson/mapboxtoken args to plotlyscopes
ayjayt 76fbc60
docs: update README and LICENSE and add code of conduct (#208)
gvwilson 110da7a
Commit vendored subdirs
ayjayt 2c33620
Change mathjax vendor strategy
ayjayt c26ea7e
Merge remote-tracking branch 'refs/remotes/origin/devtools/main' into…
ayjayt 97513dd
Remove debug messages
ayjayt cd8060f
Fix vendor + tempfiles:
ayjayt 0b6114d
Set headless=True
ayjayt a701db2
Re-enable pdf printing
ayjayt 504f65a
Enable concurrent use of old api w/ active asyncio
ayjayt f9964d2
Lint: remove unused dep
ayjayt 677c271
Allow plotly.scope to pass debug
ayjayt 54685ac
Upgrade to choreographer 0.99.2
ayjayt 597f9f8
Add debug printing everywhere
ayjayt ca3e535
Add debug function to get window status during debug
ayjayt cae9d54
Improve js debug + fix typo there
ayjayt cb72d4f
Bump dependency
ayjayt 341a0bc
Improve js logger
ayjayt 27bade3
Add pdf features to async template
ayjayt 7403d53
Organize command order
ayjayt 6617f6f
Add timeout option to to_image
ayjayt cc029d0
Add timeout to deps
ayjayt a455768
Change temporary directory path
ayjayt 4e2696e
Simplify choreographer commands
ayjayt d40b984
Add better error handling
ayjayt 70d4368
Move all debug to stderr
ayjayt e2b31f9
Add method of injecting debug to old api
ayjayt b2d29da
Add manual test
ayjayt b2f5c3a
Bump choreo version dep
ayjayt ce8b8c5
Make js error reporter clearer for searching
ayjayt 6acbf53
Add more vendor to pyproject
ayjayt db47113
Port html changes from ~2 commits to dyn html
ayjayt 0ba181c
Transfer debug value more reliably
ayjayt cdd0be3
Zip test results in manual.py
ayjayt 0e5f887
Improve test verbosity
ayjayt d1201c3
Add test-results to gitignore
ayjayt 0689bfd
Add _ option to env var since - not compat
ayjayt 0493d3d
Revert debug_browser back to debug, not stderr
ayjayt a8f7a56
Allow setting of kaleido tmpdir
ayjayt a442da8
Permeate tmp_path in kaledio to choreo.Browser
ayjayt a20db83
Bump choreo dep to 0.99.6
ayjayt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
name: ruff-wf | ||
on: pull_request | ||
jobs: | ||
ruff: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: chartboost/ruff-action@v1 | ||
with: | ||
src: './src/py' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
name: test-wf | ||
on: pull_request | ||
jobs: | ||
test-linux: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-python@v1 | ||
- name: Install Dependencies | ||
run: sudo apt-get update && sudo apt-get install chromium-browser | ||
- name: Install kaleido | ||
run: ls && pip install src/py/.[dev] | ||
- name: test | ||
run: pytest | ||
timeout-minutes: 1 | ||
test-windows: | ||
runs-on: windows-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-python@v5 | ||
- name: Install Dependencies | ||
run: choco install googlechrome -y --ignore-checksums | ||
- name: Install kaleido | ||
run: pip install src/py/.[dev] | ||
- name: test | ||
run: pytest | ||
timeout-minutes: 1 | ||
test-mac: | ||
runs-on: macos-latest | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-python@v5 | ||
- name: Install Dependencies | ||
run: brew install google-chrome | ||
- name: Install kaleido | ||
run: pip install src/py/.[dev] | ||
- name: test | ||
run: pytest | ||
timeout-minutes: 1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,32 +1,15 @@ | ||
repos/CREDITS.html | ||
repos/src | ||
repos/depot_tools | ||
*.DS_Store | ||
*.kate-swp | ||
repos/.cipd/ | ||
repos/.gclient_entries | ||
repos/.idea | ||
repos/build | ||
repos/cmake-build-debug | ||
repos/kaleido/js/node_modules | ||
repos/kaleido/js/build | ||
repos/kaleido/version | ||
repos/kaleido/LICENSE.txt | ||
repos/kaleido/README.md | ||
repos/kaleido/py/LICENSE.txt | ||
repos/kaleido/py/README.md | ||
repos/kaleido/py/tests/baselines/plotly/failed | ||
repos/kaleido/artifacts | ||
repos/kaleido/kaleido_artifacts*.zip | ||
# Py Build Stuff | ||
*.pyc | ||
win_toolchain/*.zip | ||
repos/kaleido/py/kaleido/executable | ||
repos/kaleido/py/kaleido/_version.py | ||
repos/kaleido/py/build/ | ||
repos/kaleido/py/dist/ | ||
*.egg-info/ | ||
repos/kaleido/py/scratch/ | ||
.idea/ | ||
repos/CREDITS.html | ||
repos/*.tar.gz | ||
__pycache__ | ||
|
||
# Text Editor Stuff | ||
*.DS_Store | ||
*.kate-swp | ||
*.sw* | ||
|
||
# Local Environment | ||
.venv | ||
|
||
# Artifacts from Build | ||
src/js/build |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
- [ ] #1: Vendor mathjax | ||
- [ ] #2: Add switch deprecation warnings (See TODO) | ||
- [ ] #3: TODO: Obey plolty versions switches (plotlyjs, mathjax, openmapbox) | ||
- [x] #4: Build not picking up version tag :-( <-- not picking up repo at all | ||
- [x] #5: Can't import | ||
- [ ] #6: Will permanently need more from old api (prepare spec) | ||
- [ ] #7: Move over more from devtools? | ||
|
||
|
||
|
||
NOTES: | ||
Eliminated conda search for mathjax, they can use a custom path |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete this file and move issues into the repo (?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was afraid of them getting lost in the github tho lol, but yeah