test: cleanup pmempool_[!check] from deprecated tests

[janekmi]

This change is 

[codecov]

Codecov Report

Merging #5749 (c951317) into master (e2d0619) will decrease coverage by 1.42%.
The diff coverage is n/a.

❗ Current head c951317 differs from pull request most recent head 5e1e291. Consider uploading reports for the commit 5e1e291 to get more accurate results

@@            Coverage Diff             @@
##           master    #5749      +/-   ##
==========================================
- Coverage   72.35%   70.94%   -1.42%     
==========================================
  Files         143      143              
  Lines       21982    21985       +3     
  Branches     3697     3699       +2     
==========================================
- Hits        15906    15598     -308     
- Misses       6076     6387     +311     

[grom72]

Reviewed 31 of 31 files at r1, 2 of 36 files at r2.
Reviewable status: 33 of 67 files reviewed, 1 unresolved discussion (waiting on @janekmi)

---

src/test/pmempool_sync/TEST26 line 48 at r2 (raw file):

# Remove poolset
expect_normal_exit $PMEMPOOL$EXESUFFIX rm $POOLSET

What is the purpose of this new version of the test?

[janekmi]

Reviewable status: 8 of 68 files reviewed, 1 unresolved discussion (waiting on @grom72)

---

src/test/pmempool_sync/TEST26 line 48 at r2 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

What is the purpose of this new version of the test?

Exactly the same. As far as I can tell, this test checked exactly the same scenario for both obj and log pools.
I have just dropped the log version. It seems the obj version is still valid without it.

[grom72]

Reviewed 20 of 36 files at r2, 16 of 32 files at r3, all commit messages.
Reviewable status: 38 of 68 files reviewed, 3 unresolved discussions (waiting on @janekmi)

---

ChangeLog line 5 at r3 (raw file):

	This release:
	- removes libpmempool API tests that use log/blk/btt pool types (partially)
	- removes pmempool !check tests that use log/blk/btt pool types

Suggestion:

removes pmempool_check

---

src/test/pmempool_dump/out0.log.match line 2 at r3 (raw file):

TEST
TEST

Would it be possible to remove this file if it is empty?

[grom72]

Reviewed 14 of 36 files at r2, 16 of 32 files at r3.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi)

[osalyk]

Reviewed 36 of 36 files at r2, 32 of 32 files at r3, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @janekmi)

---

src/test/pmempool_dump/out0.log.match line 2 at r3 (raw file):

It should be err0.log.match

---

src/test/pmempool_info/out27.log.match line 36 at r3 (raw file):

Heap size                : $(*)
Checksum                 : $(*) [OK]
Root offset              : $(*)

EOL

---

src/test/pmempool_rm/TEST0 line 18 at r3 (raw file):

rm -f $LOG && touch $LOG

# Create pmemobj

Suggestion:

Create pmemobj pool

[janekmi]

Reviewable status: 63 of 68 files reviewed, 5 unresolved discussions (waiting on @grom72 and @osalyk)

---

ChangeLog line 5 at r3 (raw file):

	This release:
	- removes libpmempool API tests that use log/blk/btt pool types (partially)
	- removes pmempool !check tests that use log/blk/btt pool types

No. I mean it. This PR touches everything but pmempool_check. Hence the exclamation mark states the opposite of the check.

---

src/test/pmempool_dump/out0.log.match line 2 at r3 (raw file):

Previously, grom72 (Tomasz Gromadzki) wrote…

Would it be possible to remove this file if it is empty?

Done.

---

src/test/pmempool_dump/out0.log.match line 2 at r3 (raw file):

Previously, osalyk (Oksana Sałyk) wrote…

It should be err0.log.match

Done.

---

src/test/pmempool_info/out27.log.match line 36 at r3 (raw file):

Previously, osalyk (Oksana Sałyk) wrote…

EOL

Done.

---

src/test/pmempool_rm/TEST0 line 18 at r3 (raw file):

rm -f $LOG && touch $LOG

# Create pmemobj

Done.

[grom72]

Reviewed 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @osalyk)

[grom72]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @osalyk)

[osalyk]

Reviewed 4 of 5 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @janekmi)