Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pool: remove unreachable code #5800

Merged
merged 1 commit into from
Jul 14, 2023
Merged

pool: remove unreachable code #5800

merged 1 commit into from
Jul 14, 2023

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented Jul 14, 2023 •
edited by pbalcer
Loading

@grom72
pool: remove unreachable code
59b0015 
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
@grom72 grom72 added the sprint goal This pull request is part of the ongoing sprint label Jul 14, 2023
@grom72 grom72 added this to the 2.0.0 milestone Jul 14, 2023
@grom72 grom72 requested review from janekmi and osalyk July 14, 2023 07:42
janekmi
janekmi approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #5800 (59b0015) into master (91711db) will not change coverage.
The diff coverage is 33.33%.

@@           Coverage Diff           @@
##           master    #5800   +/-   ##
=======================================
  Coverage   70.98%   70.98%           
=======================================
  Files         131      131           
  Lines       19175    19175           
  Branches     3193     3193           
=======================================
  Hits        13612    13612           
  Misses       5563     5563

osalyk
osalyk approved these changes Jul 14, 2023
View reviewed changes
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@janekmi janekmi merged commit 1d3c908 into pmem:master Jul 14, 2023
@grom72 grom72 deleted the pmempool-coverity-fix branch October 24, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osalyk osalyk osalyk approved these changes

@janekmi janekmi janekmi approved these changes

Assignees
No one assigned
Labels
sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@grom72 @janekmi @osalyk