Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: introduce fuses against ill-considered use of NDCTL_ENABLE=n (fix) #6062

Closed
wants to merge 2 commits into from

Conversation

janekmi
Copy link
Contributor

@janekmi janekmi commented Mar 20, 2024

@janekmi janekmi added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels Mar 20, 2024
@janekmi janekmi requested review from grom72 and osalyk March 20, 2024 13:17
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.12%. Comparing base (204bdff) to head (72f9cee).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6062      +/-   ##
==========================================
- Coverage   70.13%   70.12%   -0.01%     
==========================================
  Files         133      133              
  Lines       19565    19565              
  Branches     3261     3261              
==========================================
- Hits        13721    13720       -1     
- Misses       5844     5845       +1     

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)


.github/actions/pmem_test_prepare/action.yml line 45 at r1 (raw file):

        NDCTL_ENABLE: ${{ inputs.ndctl_enable }}
        PMEMOBJ_IGNORE_DIRTY_SHUTDOWN: ${{ fromJSON(inputs._env_ignore_dict)[inputs.ndctl_enable] }}
        PMEMOBJ_IGNORE_BAD_BLOCKS: ${{ fromJSON(inputs._env_ignore_dict)[inputs.ndctl_enable] }}

https://docs.github.com/en/actions/learn-github-actions/expressions#example

Suggestion:

        PMEMOBJ_IGNORE_DIRTY_SHUTDOWN: ${{ inputs.ndctl_enable == 'y' && 'y' || 'n' }}
        PMEMOBJ_IGNORE_BAD_BLOCKS: ${{ inputs.ndctl_enable == 'y' && 'y' || 'n' }}

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)

…(fix)

Ref: #5946

Signed-off-by: Jan Michalski <jan.michalski@intel.com>
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)

a discussion (no related file):
It is here:
5f00672


@janekmi
Copy link
Contributor Author

janekmi commented Mar 20, 2024

Included in #5950.

@janekmi janekmi closed this Mar 20, 2024
@janekmi janekmi deleted the NDCTL_ENABLE-sealing-fix branch April 16, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants