-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common: introduce fuses against ill-considered use of NDCTL_ENABLE=n (fix) #6062
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6062 +/- ##
==========================================
- Coverage 70.13% 70.12% -0.01%
==========================================
Files 133 133
Lines 19565 19565
Branches 3261 3261
==========================================
- Hits 13721 13720 -1
- Misses 5844 5845 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)
.github/actions/pmem_test_prepare/action.yml
line 45 at r1 (raw file):
NDCTL_ENABLE: ${{ inputs.ndctl_enable }} PMEMOBJ_IGNORE_DIRTY_SHUTDOWN: ${{ fromJSON(inputs._env_ignore_dict)[inputs.ndctl_enable] }} PMEMOBJ_IGNORE_BAD_BLOCKS: ${{ fromJSON(inputs._env_ignore_dict)[inputs.ndctl_enable] }}
https://docs.github.com/en/actions/learn-github-actions/expressions#example
Suggestion:
PMEMOBJ_IGNORE_DIRTY_SHUTDOWN: ${{ inputs.ndctl_enable == 'y' && 'y' || 'n' }}
PMEMOBJ_IGNORE_BAD_BLOCKS: ${{ inputs.ndctl_enable == 'y' && 'y' || 'n' }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)
…(fix) Ref: #5946 Signed-off-by: Jan Michalski <jan.michalski@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @janekmi and @osalyk)
a discussion (no related file):
It is here:
5f00672
Included in #5950. |
Ref: #5946
Preview: https://github.com/pmem/pmdk/actions/runs/8359582617
This change is