Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: introduce fuses against ill-considered use of NDCTL_ENABLE=n (fix) #6062

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/actions/pmem_test_prepare/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,17 @@ inputs:
description: Build with the fault injection capability
required: false
default: '0'
_env_ignore_dict:
description: |
Dictionary providing the PMEMOBJ_IGNORE_(DIRTY_SHUTDOWN|BAD_BLOCKS) values
required to acknowledge missing functionality. Indexed by the NDCTL_ENABLE
value.
required: false
default: |
{
"n": "y",
"y": "n"
}
runs:
using: composite
steps:
Expand All @@ -30,6 +41,8 @@ runs:
- env:
FAULT_INJECTION: ${{ inputs.fault_injection }}
NDCTL_ENABLE: ${{ inputs.ndctl_enable }}
PMEMOBJ_IGNORE_DIRTY_SHUTDOWN: ${{ fromJSON(inputs._env_ignore_dict)[inputs.ndctl_enable] }}
PMEMOBJ_IGNORE_BAD_BLOCKS: ${{ fromJSON(inputs._env_ignore_dict)[inputs.ndctl_enable] }}
run: |
echo '::group::Build'
$WORKDIR/build-pmdk.sh
Expand Down
70 changes: 35 additions & 35 deletions .github/workflows/pmem_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,52 +11,52 @@ on:

jobs:
# Test the default build with the basic test suite.
Basic:
uses: ./.github/workflows/pmem_test_matrix.yml
with:
# Exclude all Valgrind tests. All tests employing Valgrind tooling are run
# in the dedicated workflows below.
force_enable: '["none"]'
# Basic:
# uses: ./.github/workflows/pmem_test_matrix.yml
# with:
# # Exclude all Valgrind tests. All tests employing Valgrind tooling are run
# # in the dedicated workflows below.
# force_enable: '["none"]'


# Test the default build with force-enabled Valgrind tooling for (persistent)
# memory error detection.
Memory:
uses: ./.github/workflows/pmem_test_matrix.yml
with:
force_enable: '["pmemcheck", "memcheck"]'
# Memory:
# uses: ./.github/workflows/pmem_test_matrix.yml
# with:
# force_enable: '["pmemcheck", "memcheck"]'


# Test the default build with force-enabled Valgrind tooling for thread error
# detection.
Thread:
uses: ./.github/workflows/pmem_test_matrix.yml
with:
force_enable: '["drd", "helgrind"]'
# 9h = 7h20m (the longest workflow execution time) + ~20% leeway.
timeout_minutes: 540
# Thread:
# uses: ./.github/workflows/pmem_test_matrix.yml
# with:
# force_enable: '["drd", "helgrind"]'
# # 9h = 7h20m (the longest workflow execution time) + ~20% leeway.
# timeout_minutes: 540


# Static builds are tested in this limited scope only.
static:
name: Static
if: github.repository == 'pmem/pmdk'
runs-on: [self-hosted, rhel]
strategy:
fail-fast: false
matrix:
build: [static_debug, static_nondebug]

steps:
- uses: actions/checkout@v4

- name: Test prepare
uses: ./.github/actions/pmem_test_prepare

- name: Test run
uses: ./.github/actions/pmem_test_run
with:
build: ${{ matrix.build }}
# static:
# name: Static
# if: github.repository == 'pmem/pmdk'
# runs-on: [self-hosted, rhel]
# strategy:
# fail-fast: false
# matrix:
# build: [static_debug, static_nondebug]

# steps:
# - uses: actions/checkout@v4

# - name: Test prepare
# uses: ./.github/actions/pmem_test_prepare

# - name: Test run
# uses: ./.github/actions/pmem_test_run
# with:
# build: ${{ matrix.build }}


# Testing the fault injection scenarios requires including this capability
Expand Down
Loading