-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
utils: change lower_limit #6078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72 and @osalyk)
.github/workflows/scan_stack_usage.yml
line 58 at r1 (raw file):
# 16kB = Stack allocated for a single Argobot's ULT # 4kB = a maximum DAOS' stack usage up to calling a PMDK API calls # 784B = safety margin
The margin has decreased not grown. 😉
Suggestion:
# 16kB - 4kB - 752B = 11536B
# 16kB = Stack allocated for a single Argobot's ULT
# 4kB = a maximum DAOS' stack usage up to calling a PMDK API calls
# 752B = safety margin
2bf967d
to
5819df2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)
.github/workflows/scan_stack_usage.yml
line 58 at r1 (raw file):
Previously, janekmi (Jan Michalski) wrote…
The margin has decreased not grown. 😉
Right, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)
The problem was observed and confirmed only on Ubuntu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a short info that this problem is observed and confirmed only on Ubuntu?
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)
5819df2
to
a8b1cc6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @osalyk)
The problem was observed and confirmed only on Ubuntu
https://github.com/pmem/pmdk/actions/runs/8690027560/job/23828976964
This change is