Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils: change lower_limit #6078

Merged
merged 1 commit into from
Apr 17, 2024
Merged

utils: change lower_limit #6078

merged 1 commit into from
Apr 17, 2024

Conversation

osalyk
Copy link
Contributor

@osalyk osalyk commented Apr 15, 2024

The problem was observed and confirmed only on Ubuntu

https://github.com/pmem/pmdk/actions/runs/8690027560/job/23828976964


This change is Reviewable

@osalyk osalyk added sprint goal This pull request is part of the ongoing sprint no changelog Add to skip the changelog check on your pull request labels Apr 15, 2024
@osalyk osalyk requested review from grom72 and janekmi April 15, 2024 13:47
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72 and @osalyk)


.github/workflows/scan_stack_usage.yml line 58 at r1 (raw file):

          # 16kB = Stack allocated for a single Argobot's ULT
          #  4kB = a maximum DAOS' stack usage up to calling a PMDK API calls
          #  784B = safety margin

The margin has decreased not grown. 😉

Suggestion:

          # 16kB - 4kB - 752B = 11536B
          # 16kB = Stack allocated for a single Argobot's ULT
          #  4kB = a maximum DAOS' stack usage up to calling a PMDK API calls
          #  752B = safety margin

Copy link
Contributor Author

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)


.github/workflows/scan_stack_usage.yml line 58 at r1 (raw file):

Previously, janekmi (Jan Michalski) wrote…

The margin has decreased not grown. 😉

Right, thanks

Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

The problem was observed and confirmed only on Ubuntu
Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a short info that this problem is observed and confirmed only on Ubuntu?

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

Copy link
Contributor

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @osalyk)

@grom72 grom72 merged commit 3a208d6 into master Apr 17, 2024
6 of 7 checks passed
@osalyk osalyk deleted the stack_usage_limit branch April 18, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Add to skip the changelog check on your pull request sprint goal This pull request is part of the ongoing sprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants