Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utils: change lower_limit #6078

Merged
merged 1 commit into from
Apr 17, 2024
Merged

utils: change lower_limit #6078

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/scan_stack_usage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ jobs:
./make_extra.py
./make_cflow.sh
# The lower limit comes up from the DAOS memory requirements.
# 16kB - 4kB - 768B = 11520B
# 16kB - 4kB - 752B = 11536B
# 16kB = Stack allocated for a single Argobot's ULT
# 4kB = a maximum DAOS' stack usage up to calling a PMDK API calls
# 768B = safety margin
# 752B = safety margin
# ~ = Some OSes, e.g. Ubuntu 22.04, generate call stacks of size
# a little bit over the exact limit which is not deemed a problem at the moment.
./make_call_stacks.py --filter-api-file examples/api_filter.txt --filter-lower-limit 11520
./make_call_stacks.py --filter-api-file examples/api_filter.txt --filter-lower-limit 11536

- name: List per-function stack usage for all call stacks of interest
working-directory: ${{ env.CALL_STACKS_TOOLS_PATH }}
Expand Down
2 changes: 1 addition & 1 deletion utils/call_stacks_analysis/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
./make_extra.py && \
./make_cflow.sh && \
./make_call_stacks.py --filter-api-file examples/api_filter.txt \
--filter-lower-limit 11520 --dump-all-stacks
--filter-lower-limit 11536 --dump-all-stacks
```

If succesfull, it produces:
Expand Down
Loading