Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start.sh: print warnings on unusual exit codes from the server process #6497

Merged
merged 6 commits into from
Nov 15, 2024

Conversation

dktapps
Copy link
Member

@dktapps dktapps commented Nov 12, 2024

Introduction

This has been sitting idle on a branch for a couple of years. Not sure why it hasn't been merged as it looks basically fine as far as I can tell.

Changes

Behavioural changes

start.sh will now print warnings if the server experiences any of the following errors: SIGSEGV, SIGABRT, SIGKILL, any other anomalous exit code

Tests

Not tested, just found this while cleaning out old branches and thought it might be worth formally proposing

I tested this PR by doing the following (tick all that apply):

  • Writing PHPUnit tests (commit these in the tests/phpunit folder)
  • Playtesting using a Minecraft client (provide screenshots or a video)
  • Writing a test plugin (provide the code and sample output)
  • Other (provide details)

@dktapps dktapps added Type: Enhancement Contributes features or other improvements to PocketMine-MP Category: UI Related to the user interface (e.g. commands, terminal output) labels Nov 12, 2024
@dktapps dktapps requested a review from a team as a code owner November 12, 2024 15:23
@dktapps dktapps changed the base branch from stable to minor-next November 12, 2024 15:24
github-actions[bot]
github-actions bot previously approved these changes Nov 12, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 12, 2024
github-actions[bot]
github-actions bot previously approved these changes Nov 12, 2024
@dktapps dktapps dismissed github-actions[bot]’s stale review November 15, 2024 20:37

I don't know why this is still valid

@dktapps dktapps closed this Nov 15, 2024
@dktapps dktapps reopened this Nov 15, 2024
@dktapps dktapps closed this Nov 15, 2024
@dktapps dktapps reopened this Nov 15, 2024
@dktapps
Copy link
Member Author

dktapps commented Nov 15, 2024

Sorry for the spam, just testing github actions

@dktapps dktapps merged commit 4b630cb into minor-next Nov 15, 2024
59 checks passed
@dktapps dktapps deleted the bootstrap-exit-warnings branch November 15, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: UI Related to the user interface (e.g. commands, terminal output) Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants