-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start.sh: print warnings on unusual exit codes from the server process #6497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
added
Type: Enhancement
Contributes features or other improvements to PocketMine-MP
Category: UI
Related to the user interface (e.g. commands, terminal output)
labels
Nov 12, 2024
ipad54
approved these changes
Nov 15, 2024
dktapps
dismissed
github-actions[bot]’s stale review
November 15, 2024 20:37
I don't know why this is still valid
Sorry for the spam, just testing github actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category: UI
Related to the user interface (e.g. commands, terminal output)
Type: Enhancement
Contributes features or other improvements to PocketMine-MP
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This has been sitting idle on a branch for a couple of years. Not sure why it hasn't been merged as it looks basically fine as far as I can tell.
Changes
Behavioural changes
start.sh
will now print warnings if the server experiences any of the following errors: SIGSEGV, SIGABRT, SIGKILL, any other anomalous exit codeTests
Not tested, just found this while cleaning out old branches and thought it might be worth formally proposing
I tested this PR by doing the following (tick all that apply):
tests/phpunit
folder)