Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start.sh: print warnings on unusual exit codes from the server process #6497

Merged
merged 6 commits into from
Nov 15, 2024
Merged

start.sh: print warnings on unusual exit codes from the server process #6497

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dec17ca
Added warnings to start.sh about non-zero exit codes
dktapps Apr 2, 2022
5d1a309
added uncommitted changes
dktapps Apr 4, 2022
0fdb04a
Merge branch 'minor-next' into bootstrap-exit-warnings
dktapps Nov 12, 2024
9c6d83e
wtf shellcheck seriously
dktapps Nov 12, 2024
0c41260
Merge branch 'minor-next' into bootstrap-exit-warnings
dktapps Nov 15, 2024
6052d6d
Merge branch 'minor-next' into bootstrap-exit-warnings
dktapps Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion start.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,27 @@ fi

LOOPS=0

handle_exit_code() {
local exitcode=$1
if [ "$exitcode" -eq 134 ] || [ "$exitcode" -eq 139 ]; then #SIGABRT/SIGSEGV
echo ""
echo "ERROR: The server process was killed due to a critical error (code $exitcode) which could indicate a problem with PHP."
echo "Updating your PHP binary is recommended."
echo "If this keeps happening, please open a bug report."
echo ""
dktapps marked this conversation as resolved.
Show resolved Hide resolved
elif [ "$exitcode" -eq 143 ]; then #SIGKILL, maybe user intervention
echo ""
echo "WARNING: Server was forcibly killed!"
echo "If you didn't kill the server manually, this probably means the server used too much memory and was killed by the system's OOM Killer."
echo "Please ensure your system has enough available RAM."
echo ""
elif [ "$exitcode" -ne 0 ] && [ "$exitcode" -ne 137 ]; then #normal exit / SIGTERM
echo ""
echo "WARNING: Server did not shut down correctly! (code $exitcode)"
echo ""
fi
}

set +e

if [ "$DO_LOOP" == "yes" ]; then
Expand All @@ -52,11 +73,15 @@ if [ "$DO_LOOP" == "yes" ]; then
echo "Restarted $LOOPS times"
fi
"$PHP_BINARY" "$POCKETMINE_FILE" "$@"
handle_exit_code $?
echo "To escape the loop, press CTRL+C now. Otherwise, wait 5 seconds for the server to restart."
echo ""
sleep 5
((LOOPS++))
done
else
exec "$PHP_BINARY" "$POCKETMINE_FILE" "$@"
"$PHP_BINARY" "$POCKETMINE_FILE" "$@"
exitcode=$?
handle_exit_code $exitcode
exit $exitcode
fi