Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vanilla): createSnapshot #970

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix(vanilla): createSnapshot #970

merged 1 commit into from
Oct 14, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Oct 14, 2024

If I'm not mistaken, we should only run ensureVersion at the top object.

@vercel Vercel
Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 6:18am

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link

Size Change: -21 B (-0.17%)

Total Size: 12 kB

Filename Size Change
./dist/esm/vanilla.mjs 2.34 kB -10 B (-0.43%)
./dist/vanilla.js 2.37 kB -11 B (-0.46%)
ℹ️ View Unchanged
Filename Size
./dist/esm/index.mjs 63 B
./dist/esm/react.mjs 691 B
./dist/esm/react/utils.mjs 257 B
./dist/esm/utils.mjs 68 B
./dist/esm/vanilla/utils.mjs 2.38 kB
./dist/index.js 243 B
./dist/react.js 681 B
./dist/react/utils.js 278 B
./dist/utils.js 248 B
./dist/vanilla/utils.js 2.41 kB

compressed-size-action

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 14, 2024

Open in Stackblitz

More templates

pnpm add https://pkg.pr.new/valtio@970

commit: c3af924

@dai-shi dai-shi merged commit 487ded5 into main Oct 14, 2024
29 checks passed
@dai-shi dai-shi deleted the fix/vanilla/create-snapshot branch October 14, 2024 11:38
dai-shi added a commit that referenced this pull request Oct 30, 2024
@dai-shi
Revert "fix(vanilla): createSnapshot (#970)"
44d4a28 
This reverts commit 487ded5.
@dai-shi dai-shi mentioned this pull request Oct 30, 2024
Merged
1 task
dai-shi added a commit that referenced this pull request Nov 5, 2024
@dai-shi
fix(vanilla): revert #970 (#986)
bbe3c3a 
* add a failing test

* add more basic test

* Revert "fix(vanilla): createSnapshot (#970)"

This reverts commit 487ded5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dai-shi