fixed issue with .has() when new value is added and then deleted or c…

[overthemike]

…leared

Related Bug Reports or Discussions

#979
Fixes #
#979

Summary

Accessing this.index in the has method doesn't seem to work when a new item is added and then deleted (or cleared) at a later time. Accessing the this.data.length property fixes this issue.

Check List

• [ x ] pnpm run prettier for formatting code and docs

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
valtio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 26, 2024 7:40am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[pkg-pr-new]

Open in Stackblitz

More templates

• counter
• editor-proxyWithHistory
• valtio-photo-booth-demo

pnpm add https://pkg.pr.new/valtio@981

commit: bab9c99

[github-actions]

Size Change: +49 B (+0.36%)

Total Size: 13.6 kB

Filename	Size	Change
./dist/esm/vanilla/utils.mjs	3.15 kB	+25 B (+0.8%)
./dist/vanilla/utils.js	3.18 kB	+24 B (+0.76%)

ℹ️ View Unchanged

Filename	Size
./dist/esm/index.mjs	63 B
./dist/esm/react.mjs	691 B
./dist/esm/react/utils.mjs	257 B
./dist/esm/utils.mjs	68 B
./dist/esm/vanilla.mjs	2.34 kB
./dist/index.js	243 B
./dist/react.js	681 B
./dist/react/utils.js	278 B
./dist/utils.js	248 B
./dist/vanilla.js	2.37 kB

_{compressed-size-action}

[dai-shi]

Thanks for working on it. Is it possible to add a test?

[dai-shi]

it probably requires more.

[overthemike]

Is there anything else that needs doing before this gets merged?

[dai-shi]

Looks good overall.

[dai-shi]

This causes extra rerenders with .has(), which doesn't seem ideal, but can't be helped. It's ironic that the use of .has() should be discouraged, even though proxyMap/Set should exist for performance.

[overthemike]

Yeah - .has() essentially needs to check if the value exists every time the data changes :\

[overthemike]

Are we waiting on anything to get this merged and get a patch version published?

[dai-shi]

https://github.com/pmndrs/valtio/releases/tag/v2.1.1