Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed issue with .has() when new value is added and then deleted or c… #981

Merged
merged 9 commits into from
Oct 27, 2024
Merged

fixed issue with .has() when new value is added and then deleted or c… #981

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
2d3714c
fixed issue with .has() when new value is added and then deleted or c…
overthemike Oct 23, 2024
dd50d04
removed unneeded variable assignment
overthemike Oct 24, 2024
0f3512c
Merge branch 'main' into 979
overthemike Oct 24, 2024
e9d75ad
added tests for adding and removing data in proxySet and proxyMap to …
overthemike Oct 24, 2024
660866e
fixed typo in test
overthemike Oct 24, 2024
f1a4d82
added epoch to proxySet and proxyMap to keep track of versioning
overthemike Oct 24, 2024
77a982c
added tests for using .clear on proxyMap and proxySet
overthemike Oct 24, 2024
07e883c
added more tests for useSnapshot
overthemike Oct 26, 2024
bab9c99
added comment for epoch in proxyMap
overthemike Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/vanilla/utils/proxyMap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,8 @@ export function proxyMap<K, V>(entries?: Iterable<[K, V]> | undefined | null) {
has(key: K) {
const map = getMapForThis(this)
const exists = map.has(key)
if (!exists) {
// eslint-disable-next-line @typescript-eslint/no-unused-expressions
this.index // touch property for tracking
}
// eslint-disable-next-line @typescript-eslint/no-unused-expressions
this.data.length // touch property for tracking
overthemike marked this conversation as resolved.
Show resolved Hide resolved
return exists
overthemike marked this conversation as resolved.
Show resolved Hide resolved
},
set(key: K, value: V) {
Expand Down
6 changes: 2 additions & 4 deletions src/vanilla/utils/proxySet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,8 @@ export function proxySet<T>(initialValues?: Iterable<T> | null) {
const map = getMapForThis(this)
const v = maybeProxify(value)
const exists = map.has(v)
if (!exists) {
// eslint-disable-next-line @typescript-eslint/no-unused-expressions
this.index // touch property for tracking
}
// eslint-disable-next-line @typescript-eslint/no-unused-expressions
this.data.length // touch property for tracking
return exists
},
add(value: T) {
Expand Down