Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve timers #73

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Improve timers #73

merged 2 commits into from
Mar 12, 2024

Conversation

zfergus
Copy link
Member

@zfergus zfergus commented Mar 12, 2024

  • Move timers into DescentStrategy
  • Move timers into LineSearch

- Move timers into DescentStrategy
- Move timers into LineSearch
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 98.50746% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 87.62%. Comparing base (1b142d3) to head (5705af7).

Files Patch % Lines
.../polysolve/nonlinear/descent_strategies/Newton.cpp 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   87.51%   87.62%   +0.11%     
==========================================
  Files          48       48              
  Lines        2026     2045      +19     
==========================================
+ Hits         1773     1792      +19     
  Misses        253      253              
Flag Coverage Δ
polysolve 87.62% <98.50%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zfergus zfergus merged commit 9f8a5e1 into main Mar 12, 2024
9 checks passed
@zfergus zfergus deleted the improve-timers branch March 12, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant