[SpatialPartitioning] Change part of the kdtree API #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azaleostu
force-pushed
the
kdtree-api-changes
branch
from
3233c96 to
086c5ef
Compare
azaleostu
force-pushed
the
kdtree-api-changes
branch
from
086c5ef to
53b1fba
Compare
nmellado
approved these changes
Dec 15, 2023
nmellado
requested changes
Dec 15, 2023
nmellado
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames some of the KdTree accessors and changes its
to_stringmethod to aprintmethod taking anstd::ostreamas argument. This PR also adds anoperator<<overload for the KdTree.Most notably, the
index_datamethod was renamed tosamplesto work on solving the confusion raised by how the KdTree handles sampling (see #114).