Extract Woodbury engine from DC sensitivity analysis #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
This reverts commit 4f5fbe3.
…vity or not" This reverts commit 307cc69.
This reverts commit 1d3eaad.
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
p-arvy
changed the base branch from
main
to
one-sensi-calculation-for-one-contingency
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
Hadrien-Godard
approved these changes
Jul 11, 2024
Base automatically changed from
one-sensi-calculation-for-one-contingency
to
main
July 12, 2024 14:06
# Conflicts: # src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java
Signed-off-by: p-arvy <pierre.arvy@artelys.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
…powsybl-open-loadflow into extract-woodbury-engine
annetill
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Nice work. All tests passing, including our internal cucumber tests. Maybe need a check from @jeandemanged because we create a new engine.
will have a look by the end of the day |
jeandemanged
requested changes
Jul 16, 2024
src/main/java/com/powsybl/openloadflow/sensi/WoodburyEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/sensi/WoodburyEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/sensi/WoodburyEngine.java
Outdated
Show resolved
Hide resolved
src/main/java/com/powsybl/openloadflow/sensi/DcSensitivityAnalysis.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
Signed-off-by: Hadrien <hadrien.godard@artelys.com>
jeandemanged
approved these changes
Jul 17, 2024
|
annetill
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Tests are passing: powsybl-open-rao ok and internal tests too. Note that refactoring must continue in another PR because the remaining "weird" design is that the run method of the engine takes as argument a "new flow states", slightly modified from the N states. I think this must be hidden in the engine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No.
What kind of change does this PR introduce?
The calculation associated with Woodbury equality in DC sensitivity analysis is extracted into a new class : WoodburyEngine.
What is the current behavior?
The calculations are made in DC sensitivity analysis.
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: