Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Woodbury engine from DC sensitivity analysis #1064

Merged
merged 37 commits into from
Jul 19, 2024
Merged
Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
3a731b2
Remove map on pst lost in DC sensis
p-arvy Jul 5, 2024
b1642fc
Refactor method recomputing load flows if a pst is lost
p-arvy Jul 5, 2024
ddad6d3
Case with pst or glsk/slack lost in same method
p-arvy Jul 5, 2024
5eba925
At most 1 override of flow/sensi
p-arvy Jul 8, 2024
321045f
Small clean
p-arvy Jul 8, 2024
1e68ead
Small clean
p-arvy Jul 8, 2024
516cf29
Remove distinction of cases with/without generator or load lost
p-arvy Jul 8, 2024
05ddbc1
Merge treatment of override for contingency breaking connectivity or not
p-arvy Jul 8, 2024
4ea0b54
Modify commentary
p-arvy Jul 8, 2024
5c41a7d
Revert "Modify commentary"
p-arvy Jul 9, 2024
3bf641e
Revert "Merge treatment of override for contingency breaking connecti…
p-arvy Jul 9, 2024
d819cfb
Revert "Remove distinction of cases with/without generator or load lost"
p-arvy Jul 9, 2024
f9f7f5a
Fix comment.
p-arvy Jul 9, 2024
dbda9e5
Small clean.
annetill Jul 10, 2024
63c3c65
Add comments.
p-arvy Jul 10, 2024
87db4f7
Extract Woodbury engine from DcSensitivityAnalysis
p-arvy Jul 10, 2024
6e64925
Small clean
p-arvy Jul 10, 2024
ee8ea47
Small clean
p-arvy Jul 11, 2024
84a7552
Complete comment
p-arvy Jul 11, 2024
7a78303
Update some comments
Hadrien-Godard Jul 11, 2024
1cac0f9
Merge branch 'refs/heads/main' into extract-woodbury-engine
p-arvy Jul 12, 2024
5b38eff
Fix merge
p-arvy Jul 12, 2024
3ded02b
Add constructor in WoodburyEngine
p-arvy Jul 12, 2024
cce49ca
Clean proposal.
annetill Jul 15, 2024
70ec64b
Update commentary
Hadrien-Godard Jul 15, 2024
8a184bb
Cleaning of useless code
Hadrien-Godard Jul 15, 2024
a7a88ec
Clean
Hadrien-Godard Jul 15, 2024
80721fb
Clean unused baseCaseSensitivityValue
Hadrien-Godard Jul 15, 2024
134a5d2
Clean
Hadrien-Godard Jul 15, 2024
5b2f193
Save.
annetill Jul 15, 2024
19949c3
Merge branch 'extract-woodbury-engine' of https://github.com/powsybl/…
annetill Jul 16, 2024
70186ab
Renaming.
annetill Jul 16, 2024
0c9863e
Make WoodburyEngine attributes private
Hadrien-Godard Jul 17, 2024
f169256
Merge remote-tracking branch 'origin/main' into extract-woodbury-engine
Hadrien-Godard Jul 17, 2024
f187c1a
WoodburyEngine only needs a DcEquationSystemCreationParameters object
Hadrien-Godard Jul 17, 2024
2d86eeb
Factorization
Hadrien-Godard Jul 17, 2024
d8ec86f
Merge branch 'main' into extract-woodbury-engine
annetill Jul 19, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,6 @@ enum Status {

void setFunctionReference(double functionReference);

double getBaseSensitivityValue();

void setBaseCaseSensitivityValue(double baseCaseSensitivityValue);

Status getStatus();

void setStatus(Status status);
Expand Down Expand Up @@ -142,8 +138,6 @@ protected abstract static class AbstractLfSensitivityFactor<V extends Enum<V> &

private double functionReference = 0d;

private double baseCaseSensitivityValue = Double.NaN; // the sensitivity value on pre contingency network, that needs to be recomputed if the stack distribution change

protected Status status = Status.VALID;

protected SensitivityFactorGroup<V, E> group;
Expand Down Expand Up @@ -263,16 +257,6 @@ public void setFunctionReference(double functionReference) {
this.functionReference = functionReference;
}

@Override
public double getBaseSensitivityValue() {
return baseCaseSensitivityValue;
}

@Override
public void setBaseCaseSensitivityValue(double baseCaseSensitivityValue) {
this.baseCaseSensitivityValue = baseCaseSensitivityValue;
}

@Override
public Status getStatus() {
return status;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ public final class ComputedContingencyElement {

private int contingencyIndex = -1; // index of the element in the rhs for +1-1
private int localIndex = -1; // local index of the element : index of the element in the matrix used in the setAlphas method
private double alphaForSensitivityValue = Double.NaN;
private double alphaForFunctionReference = Double.NaN;
private double alphaForPostContingencyState = Double.NaN;
private final ContingencyElement element;
private final LfBranch lfBranch;
private final ClosedBranchSide1DcFlowEquationTerm branchEquation;
Expand All @@ -56,20 +55,12 @@ private void setLocalIndex(final int index) {
this.localIndex = index;
}

public double getAlphaForSensitivityValue() {
return alphaForSensitivityValue;
public double getAlphaForPostContingencyState() {
return alphaForPostContingencyState;
}

public void setAlphaForSensitivityValue(final double alpha) {
this.alphaForSensitivityValue = alpha;
}

public double getAlphaForFunctionReference() {
return alphaForFunctionReference;
}

public void setAlphaForFunctionReference(final double alpha) {
this.alphaForFunctionReference = alpha;
public void setAlphaForPostContingencyState(double alphaForPostContingencyStates) {
this.alphaForPostContingencyState = alphaForPostContingencyStates;
}

public ContingencyElement getElement() {
Expand Down
Loading