Issue 56 track unacked; added option to disable connection pooling #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 4, 2019 20:11
…nted Signed-off-by: Claudio Fahey <claudio.fahey@dell.com>
Signed-off-by: Claudio Fahey <claudio.fahey@dell.com>
Signed-off-by: Claudio Fahey <claudio.fahey@dell.com>
Signed-off-by: Claudio Fahey <claudio.fahey@dell.com>
…re printed Signed-off-by: Claudio Fahey <claudio.fahey@dell.com>
kmgowda
reviewed
Sep 7, 2019
| } | ||
|
|
||
| @Override | ||
| public long recordWrite(byte[] data, TriConsumer record) { | ||
| CompletableFuture ret; | ||
| final long time = System.currentTimeMillis(); | ||
| record.accept(time, -1, data.length); |
There was a problem hiding this comment.
This will reduce the strength of the tool to pump more data to pravega client; this command method is used kafka bench-marking too.
implement it as different method something like "recordWriteAck" and invoke when the user specifies the "-unack true" .
There was a problem hiding this comment.
Hi @claudiofahey
I have raised the pull request : #61
to extend the tool for kafka bench-marking; if you are make any changes in the tool ; I suggest you test with kafka too; This bench-marking tool and existing kafka benchmark tool should yield same results for the single producer.
There was a problem hiding this comment.
I will update the PR once #61 has been merged to master.
|
I will resubmit this PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes various unrelated updates. Let me know if you need these as separate issues, branches, and PRs.