Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Deprecate regex property for tracing #24270

Merged
merged 1 commit into from
Dec 20, 2024
Merged

[native] Deprecate regex property for tracing #24270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions presto-docs/src/main/sphinx/presto_cpp/properties-session.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,15 +369,6 @@ The fragment id to be traced. If not specified, all fragments will be matched.

The shard id to be traced. If not specified, all shards will be matched.

``native_query_trace_task_reg_exp``
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

* **Type:** ``varchar``
* **Default value:** ``""``

The regular expression to match a task for tracing. It will be deprecated if there is
no issue with native_query_trace_fragment_id and native_query_trace_shard_id.

``native_scaled_writer_rebalance_max_memory_usage_ratio``
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Expand Down
5 changes: 0 additions & 5 deletions ...ava/com/facebook/presto/sessionpropertyproviders/NativeWorkerSessionPropertyProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ public class NativeWorkerSessionPropertyProvider
public static final String NATIVE_QUERY_TRACE_DIR = "native_query_trace_dir";
public static final String NATIVE_QUERY_TRACE_NODE_IDS = "native_query_trace_node_ids";
public static final String NATIVE_QUERY_TRACE_MAX_BYTES = "native_query_trace_max_bytes";
public static final String NATIVE_QUERY_TRACE_REG_EXP = "native_query_trace_task_reg_exp";
public static final String NATIVE_QUERY_TRACE_FRAGMENT_ID = "native_query_trace_fragment_id";
public static final String NATIVE_QUERY_TRACE_SHARD_ID = "native_query_trace_shard_id";
public static final String NATIVE_MAX_LOCAL_EXCHANGE_PARTITION_COUNT = "native_max_local_exchange_partition_count";
Expand Down Expand Up @@ -230,10 +229,6 @@ public NativeWorkerSessionPropertyProvider(FeaturesConfig featuresConfig)
"The max trace bytes limit. Tracing is disabled if zero.",
0L,
!nativeExecution),
stringProperty(NATIVE_QUERY_TRACE_REG_EXP,
"The regexp of traced task id. We only enable trace on a task if its id matches.",
"",
!nativeExecution),
stringProperty(NATIVE_OP_TRACE_DIR_CREATE_CONFIG,
"Config used to create operator trace directory. This config is provided to underlying file system and the config is free form. The form should be defined by the underlying file system.",
"",
Expand Down
8 changes: 0 additions & 8 deletions presto-native-execution/presto_cpp/main/SessionProperties.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,14 +297,6 @@ SessionProperties::SessionProperties() {
QueryConfig::kQueryTraceMaxBytes,
std::to_string(c.queryTraceMaxBytes()));

addSessionProperty(
kQueryTraceTaskRegExp,
"The regexp of traced task id. We only enable trace on a task if its id"
" matches.",
VARCHAR(),
false,
QueryConfig::kQueryTraceTaskRegExp,
c.queryTraceTaskRegExp());

addSessionProperty(
kOpTraceDirectoryCreateConfig,
Expand Down
5 changes: 0 additions & 5 deletions presto-native-execution/presto_cpp/main/SessionProperties.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,11 +227,6 @@ class SessionProperties {
static constexpr const char* kQueryTraceMaxBytes =
"native_query_trace_max_bytes";

/// The regexp of traced task id. We only enable trace on a task if its id
/// matches.
static constexpr const char* kQueryTraceTaskRegExp =
"native_query_trace_task_reg_exp";

/// Config used to create operator trace directory. This config is provided to
/// underlying file system and the config is free form. The form should be
/// defined by the underlying file system.
Expand Down
Loading