Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[native] Deprecate regex property for tracing #24270

Merged

Conversation

zation99
Copy link
Contributor

@zation99 zation99 commented Dec 17, 2024

Description

It's a follow up of #24209 . Regex property in Prestissimo can be deprecated with the two new properties.

Motivation and Context

Impact

Test Plan

e2e testing with tracing and unit tests

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Deprecated  native_query_trace_task_reg_exp session property from Prestissimo:pr:`24270`

@zation99 zation99 requested review from steveburnett, elharo and a team as code owners December 17, 2024 19:20
@zation99 zation99 requested a review from presto-oss December 17, 2024 19:20
@prestodb-ci prestodb-ci added the from:Meta PR from Meta label Dec 17, 2024
xiaoxmeng
xiaoxmeng previously approved these changes Dec 17, 2024
Copy link
Contributor

@xiaoxmeng xiaoxmeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zation99 thanks!

@zation99 zation99 force-pushed the jiaqizhang_t210646145_remove_regex_trace branch from 99828c1 to 539b9dc Compare December 18, 2024 20:44
@zation99 zation99 requested a review from xiaoxmeng December 20, 2024 20:43
@xiaoxmeng xiaoxmeng merged commit 737f5e1 into prestodb:master Dec 20, 2024
67 of 68 checks passed
@steveburnett
Copy link
Contributor

Suggest minor revision of release note entry in keeping with the Release Notes Guidelines:

== RELEASE NOTES ==

General Changes
* Remove deprecated  ``native_query_trace_task_reg_exp session`` property from Prestissimo. :pr:`24270`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:Meta PR from Meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants